You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/06/07 23:06:40 UTC

[GitHub] [cordova-plugin-statusbar] jcesarmobile opened a new pull request, #230: fix(browser): Remove invalid proxy function

jcesarmobile opened a new pull request, #230:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/230

   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   browser
   
   
   ### Motivation and Context
   Should be styleLightContent instead of styleLightContect, but that's already there, so remove the wrong one
   
   
   ### Description
   <!-- Describe your changes in detail -->
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-statusbar] jcesarmobile commented on pull request #230: fix(browser): Remove invalid proxy function

Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on PR #230:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/230#issuecomment-1149606727

   I don’t think it’s breaking, it’s been there forever, but it’s a typo and doesn’t exist on the js API, so I don’t think people would be using it.
   This proxy is just so the plugin in browser platform appears as implemented and can be “used”, but all methods will just log that the plugin is not supported and call the success callback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-statusbar] erisu commented on pull request #230: fix(browser): Remove invalid proxy function

Posted by GitBox <gi...@apache.org>.
erisu commented on PR #230:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/230#issuecomment-1149414668

   I don't know if this API was ever released in a previous version or only in the main branch, but is this removal considered as a major breaking change?
   
   Eventhough it is only removing the incorrectly spelled API, and the API with the correct spelling eixsts, this was a public API?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-statusbar] jcesarmobile merged pull request #230: fix(browser): Remove invalid proxy function

Posted by GitBox <gi...@apache.org>.
jcesarmobile merged PR #230:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/230


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org