You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/07 03:03:31 UTC
[GitHub] [incubator-doris] wsjz opened a new pull request, #9981: Fix hudi scan type
wsjz opened a new pull request, #9981:
URL: https://github.com/apache/incubator-doris/pull/9981
# Proposed changes
Obviously a little mistake
## Problem Summary:
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
Maybe have a better judge in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wsjz commented on a diff in pull request #9981: Fix hudi scan type
Posted by GitBox <gi...@apache.org>.
wsjz commented on code in PR #9981:
URL: https://github.com/apache/incubator-doris/pull/9981#discussion_r890738190
##########
fe/fe-core/src/main/java/org/apache/doris/planner/BrokerScanNode.java:
##########
@@ -152,7 +152,7 @@ public BrokerScanNode(PlanNodeId id, TupleDescriptor destTupleDesc, String planN
this.fileStatusesList = fileStatusesList;
this.filesAdded = filesAdded;
if (ConnectContext.get() != null) {
- this.userIdentity = ConnectContext.get().getUserIdentity();
Review Comment:
OK, I will close it and create new PR: this https://github.com/apache/incubator-doris/pull/9984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wsjz commented on pull request #9981: Fix hudi scan type
Posted by GitBox <gi...@apache.org>.
wsjz commented on PR #9981:
URL: https://github.com/apache/incubator-doris/pull/9981#issuecomment-1148160506
use this instead: https://github.com/apache/incubator-doris/pull/9984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wsjz closed pull request #9981: Fix hudi scan type
Posted by GitBox <gi...@apache.org>.
wsjz closed pull request #9981: Fix hudi scan type
URL: https://github.com/apache/incubator-doris/pull/9981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9981: Fix hudi scan type
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9981:
URL: https://github.com/apache/incubator-doris/pull/9981#discussion_r890730971
##########
fe/fe-core/src/main/java/org/apache/doris/planner/BrokerScanNode.java:
##########
@@ -152,7 +152,7 @@ public BrokerScanNode(PlanNodeId id, TupleDescriptor destTupleDesc, String planN
this.fileStatusesList = fileStatusesList;
this.filesAdded = filesAdded;
if (ConnectContext.get() != null) {
- this.userIdentity = ConnectContext.get().getUserIdentity();
Review Comment:
This has been changed in master branch. May be you need to rebase the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org