False Positives in Release audit problems report? - confirmation required

[Vivek Ganesan <vi...@vivekganesan.com>]

Hi,

I am on my way to contribute my first patch to hdfs.

My patch has the following files.

viv@viv-Ideapad-Z570:~/Work/hadoop-trunk$ svn stat
M 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
M 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DatanodeJspHelper.java


But, I get releaseAudit violations as follows in 
/tmp/patchReleaseAuditProblems.txt

  !????? 
/home/viv/Work/hadoop-trunk/hadoop-hdfs-project/hadoop-hdfs/build/test/data/dfs/name1/current/VERSION
  !????? 
/home/viv/Work/hadoop-trunk/hadoop-hdfs-project/hadoop-hdfs/build/test/data/dfs/name1/current/fsimage_0000000000000000000.md5
  !????? 
/home/viv/Work/hadoop-trunk/hadoop-hdfs-project/hadoop-hdfs/build/test/data/dfs/name1/current/seen_txid
  !????? 
/home/viv/Work/hadoop-trunk/hadoop-hdfs-project/hadoop-hdfs/build/test/data/dfs/name2/current/VERSION
  !????? 
/home/viv/Work/hadoop-trunk/hadoop-hdfs-project/hadoop-hdfs/build/test/data/dfs/name2/current/fsimage_0000000000000000000.md5
  !????? 
/home/viv/Work/hadoop-trunk/hadoop-hdfs-project/hadoop-hdfs/build/test/data/dfs/name2/current/seen_txid
Lines that start with ????? in the release audit report indicate files 
that do not have an Apache license header.

Actually, the build directory is not source controlled and not a part of 
the patch.

Is this a false positive?

Thanks in advance.

Regards,
Vivek Ganesan

Re: False Positives in Release audit problems report? - confirmation required

[Chris Nauroth <cn...@hortonworks.com>]

Yes, I suspect this is a false positive due to some intermediate files left
behind by a test run.  Please feel free to post your patch.

Chris Nauroth
Hortonworks
http://hortonworks.com/



On Thu, Jul 11, 2013 at 6:49 AM, Vivek Ganesan <vi...@vivekganesan.com>wrote:

> Hi,
>
> I am on my way to contribute my first patch to hdfs.
>
> My patch has the following files.
>
> viv@viv-Ideapad-Z570:~/Work/**hadoop-trunk$ svn stat
> M hadoop-hdfs-project/hadoop-**hdfs/src/test/java/org/apache/**
> hadoop/hdfs/server/datanode/**TestDatanodeJsp.java
> M hadoop-hdfs-project/hadoop-**hdfs/src/main/java/org/apache/**
> hadoop/hdfs/server/datanode/**DatanodeJspHelper.java
>
>
> But, I get releaseAudit violations as follows in /tmp/**
> patchReleaseAuditProblems.txt
>
>  !????? /home/viv/Work/hadoop-trunk/**hadoop-hdfs-project/hadoop-**
> hdfs/build/test/data/dfs/**name1/current/VERSION
>  !????? /home/viv/Work/hadoop-trunk/**hadoop-hdfs-project/hadoop-**
> hdfs/build/test/data/dfs/**name1/current/fsimage_**0000000000000000000.md5
>  !????? /home/viv/Work/hadoop-trunk/**hadoop-hdfs-project/hadoop-**
> hdfs/build/test/data/dfs/**name1/current/seen_txid
>  !????? /home/viv/Work/hadoop-trunk/**hadoop-hdfs-project/hadoop-**
> hdfs/build/test/data/dfs/**name2/current/VERSION
>  !????? /home/viv/Work/hadoop-trunk/**hadoop-hdfs-project/hadoop-**
> hdfs/build/test/data/dfs/**name2/current/fsimage_**0000000000000000000.md5
>  !????? /home/viv/Work/hadoop-trunk/**hadoop-hdfs-project/hadoop-**
> hdfs/build/test/data/dfs/**name2/current/seen_txid
> Lines that start with ????? in the release audit report indicate files
> that do not have an Apache license header.
>
> Actually, the build directory is not source controlled and not a part of
> the patch.
>
> Is this a false positive?
>
> Thanks in advance.
>
> Regards,
> Vivek Ganesan
>