You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/07 13:32:50 UTC
[GitHub] [lucene-solr] donnerpeter opened a new pull request #2315: LUCENE-9735: Hunspell: speed up flag checks by avoiding allocations
donnerpeter opened a new pull request #2315:
URL: https://github.com/apache/lucene-solr/pull/2315
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Each `Dictionary.decodeFlags` (and most `hasFlag`) checks allocated a `char[]`, in many cases only searched once
# Solution
Check for flags for the given entry ID without allocations. Instead of `BytesRefHash`, store the sorted flags in a contiguous `char[]` built in a similar way (but without hashtable overhead after it's fully built), use offsets there as ids (like `BytesRefHash` does), store the length of the sub-array in the first char at the identifying offset. Search linearly instead of binary, as it results in a bit better performance.
# Tests
I've got got 10-20% improvement on a manual check in `de` and `fr` in `TestPerformance`.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss merged pull request #2315: LUCENE-9735: Hunspell: speed up flag checks by avoiding allocations
Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #2315:
URL: https://github.com/apache/lucene-solr/pull/2315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org