You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/07/08 10:37:55 UTC
[GitHub] [camel] spenkale opened a new pull request #5813: CAMEL-16794: race condition in LoopProcessor
spenkale opened a new pull request #5813:
URL: https://github.com/apache/camel/pull/5813
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5813: CAMEL-16794: race condition in LoopProcessor
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5813:
URL: https://github.com/apache/camel/pull/5813#issuecomment-876367908
Thanks for reporting.
We should find a better fix than to synchronize the entire process method.
Can you try to investigate making the LoopState local instance, and then in the getPendingExchangesSize method you do something similar to what is done in WireTapProcessor where. there is a task counter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #5813: CAMEL-16794: race condition in LoopProcessor
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #5813:
URL: https://github.com/apache/camel/pull/5813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] spenkale commented on pull request #5813: CAMEL-16794: race condition in LoopProcessor
Posted by GitBox <gi...@apache.org>.
spenkale commented on pull request #5813:
URL: https://github.com/apache/camel/pull/5813#issuecomment-876426369
Thanks for the pointer to WireTapProcessor, I've now taken the same approach. This is actually better because the original (and the one in the current main branch) would only count the pending loops in one of the threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org