You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2014/05/10 23:54:01 UTC
Review Request 21305: SENTRY-194: Sentry script should note use Hive script
by default for service and tool execution
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21305/
-----------------------------------------------------------
Review request for sentry, Jarek Cecho and Sravya Tirukkovalur.
Bugs: SENTRY-194
https://issues.apache.org/jira/browse/SENTRY-194
Repository: sentry
Description
-------
Invoke Hadoop script from sentry script when possible.
Also removed the some of the Hadoop and Hive jars from Sentry distribution
Diffs
-----
bin/sentry 0bd37e8
sentry-binding/sentry-binding-hive/pom.xml 2ce4d87
Diff: https://reviews.apache.org/r/21305/diff/
Testing
-------
Manually test Sentry service and tool invocation. Also tested with schemaTool from the SENTRY-193 proposed patch with this change.
Thanks,
Prasad Mujumdar
Re: Review Request 21305: SENTRY-194: Sentry script should note use Hive
script by default for service and tool execution
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
> On May 13, 2014, 12:08 a.m., Sravya Tirukkovalur wrote:
> > Assuming that we recommend setting SENTRY_HOME to /usr/lib/sentry/server for starting Sentry service
> >
> > 1. I think we have to put the jars in server/lib instead?
> > 2. sentry-common is not in server's lib, but we will need it to invoke the SentryMain isnt it?
Ah ok, so it looks like sentry script is adding everything in lib and lib/server to classpath.
- Sravya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21305/#review42784
-----------------------------------------------------------
On May 12, 2014, 10:51 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21305/
> -----------------------------------------------------------
>
> (Updated May 12, 2014, 10:51 p.m.)
>
>
> Review request for sentry, Jarek Cecho and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-194
> https://issues.apache.org/jira/browse/SENTRY-194
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Invoke Hadoop script from sentry script when possible.
> Also removed the some of the Hadoop and Hive jars from Sentry distribution
>
>
> Diffs
> -----
>
> bin/sentry 0bd37e8
> sentry-binding/sentry-binding-hive/pom.xml 2ce4d87
> sentry-binding/sentry-binding-solr/pom.xml 4ed491a
> sentry-dist/src/main/assembly/bin.xml 8d9d753
> sentry-dist/src/main/assembly/src.xml 208d455
> sentry-policy/sentry-policy-db/pom.xml 59498f3
> sentry-policy/sentry-policy-search/pom.xml 55ea3c1
> sentry-provider/sentry-provider-common/pom.xml 7c17950
> sentry-provider/sentry-provider-db/pom.xml 0cda1e2
> sentry-provider/sentry-provider-file/pom.xml 60c4836
>
> Diff: https://reviews.apache.org/r/21305/diff/
>
>
> Testing
> -------
>
> Manually test Sentry service and tool invocation. Also tested with schemaTool from the SENTRY-193 proposed patch with this change.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 21305: SENTRY-194: Sentry script should note use Hive
script by default for service and tool execution
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21305/#review42784
-----------------------------------------------------------
Assuming that we recommend setting SENTRY_HOME to /usr/lib/sentry/server for starting Sentry service
1. I think we have to put the jars in server/lib instead?
2. sentry-common is not in server's lib, but we will need it to invoke the SentryMain isnt it?
- Sravya Tirukkovalur
On May 12, 2014, 10:51 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21305/
> -----------------------------------------------------------
>
> (Updated May 12, 2014, 10:51 p.m.)
>
>
> Review request for sentry, Jarek Cecho and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-194
> https://issues.apache.org/jira/browse/SENTRY-194
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Invoke Hadoop script from sentry script when possible.
> Also removed the some of the Hadoop and Hive jars from Sentry distribution
>
>
> Diffs
> -----
>
> bin/sentry 0bd37e8
> sentry-binding/sentry-binding-hive/pom.xml 2ce4d87
> sentry-binding/sentry-binding-solr/pom.xml 4ed491a
> sentry-dist/src/main/assembly/bin.xml 8d9d753
> sentry-dist/src/main/assembly/src.xml 208d455
> sentry-policy/sentry-policy-db/pom.xml 59498f3
> sentry-policy/sentry-policy-search/pom.xml 55ea3c1
> sentry-provider/sentry-provider-common/pom.xml 7c17950
> sentry-provider/sentry-provider-db/pom.xml 0cda1e2
> sentry-provider/sentry-provider-file/pom.xml 60c4836
>
> Diff: https://reviews.apache.org/r/21305/diff/
>
>
> Testing
> -------
>
> Manually test Sentry service and tool invocation. Also tested with schemaTool from the SENTRY-193 proposed patch with this change.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 21305: SENTRY-194: Sentry script should note use Hive
script by default for service and tool execution
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21305/#review42806
-----------------------------------------------------------
Ship it!
Ship It!
- Sravya Tirukkovalur
On May 12, 2014, 10:51 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21305/
> -----------------------------------------------------------
>
> (Updated May 12, 2014, 10:51 p.m.)
>
>
> Review request for sentry, Jarek Cecho and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-194
> https://issues.apache.org/jira/browse/SENTRY-194
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Invoke Hadoop script from sentry script when possible.
> Also removed the some of the Hadoop and Hive jars from Sentry distribution
>
>
> Diffs
> -----
>
> bin/sentry 0bd37e8
> sentry-binding/sentry-binding-hive/pom.xml 2ce4d87
> sentry-binding/sentry-binding-solr/pom.xml 4ed491a
> sentry-dist/src/main/assembly/bin.xml 8d9d753
> sentry-dist/src/main/assembly/src.xml 208d455
> sentry-policy/sentry-policy-db/pom.xml 59498f3
> sentry-policy/sentry-policy-search/pom.xml 55ea3c1
> sentry-provider/sentry-provider-common/pom.xml 7c17950
> sentry-provider/sentry-provider-db/pom.xml 0cda1e2
> sentry-provider/sentry-provider-file/pom.xml 60c4836
>
> Diff: https://reviews.apache.org/r/21305/diff/
>
>
> Testing
> -------
>
> Manually test Sentry service and tool invocation. Also tested with schemaTool from the SENTRY-193 proposed patch with this change.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 21305: SENTRY-194: Sentry script should note use Hive
script by default for service and tool execution
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21305/
-----------------------------------------------------------
(Updated May 12, 2014, 10:51 p.m.)
Review request for sentry, Jarek Cecho and Sravya Tirukkovalur.
Bugs: SENTRY-194
https://issues.apache.org/jira/browse/SENTRY-194
Repository: sentry
Description
-------
Invoke Hadoop script from sentry script when possible.
Also removed the some of the Hadoop and Hive jars from Sentry distribution
Diffs
-----
bin/sentry 0bd37e8
sentry-binding/sentry-binding-hive/pom.xml 2ce4d87
sentry-binding/sentry-binding-solr/pom.xml 4ed491a
sentry-dist/src/main/assembly/bin.xml 8d9d753
sentry-dist/src/main/assembly/src.xml 208d455
sentry-policy/sentry-policy-db/pom.xml 59498f3
sentry-policy/sentry-policy-search/pom.xml 55ea3c1
sentry-provider/sentry-provider-common/pom.xml 7c17950
sentry-provider/sentry-provider-db/pom.xml 0cda1e2
sentry-provider/sentry-provider-file/pom.xml 60c4836
Diff: https://reviews.apache.org/r/21305/diff/
Testing
-------
Manually test Sentry service and tool invocation. Also tested with schemaTool from the SENTRY-193 proposed patch with this change.
Thanks,
Prasad Mujumdar
Re: Review Request 21305: SENTRY-194: Sentry script should note use Hive
script by default for service and tool execution
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21305/#review42755
-----------------------------------------------------------
Thanks for taking care of it Prasad! As we are at it, can we also remove other hadoop dependencies too from the distribution. I see hadoop-common, auth and annotations. Thanks!
sentry-dist/src/main/assembly/bin.xml
<https://reviews.apache.org/r/21305/#comment76634>
Repetetion
- Sravya Tirukkovalur
On May 12, 2014, 5:19 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21305/
> -----------------------------------------------------------
>
> (Updated May 12, 2014, 5:19 p.m.)
>
>
> Review request for sentry, Jarek Cecho and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-194
> https://issues.apache.org/jira/browse/SENTRY-194
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Invoke Hadoop script from sentry script when possible.
> Also removed the some of the Hadoop and Hive jars from Sentry distribution
>
>
> Diffs
> -----
>
> bin/sentry 0bd37e8
> sentry-binding/sentry-binding-hive/pom.xml 2ce4d87
> sentry-dist/src/main/assembly/bin.xml 8d9d753
> sentry-dist/src/main/assembly/src.xml 208d455
> sentry-provider/sentry-provider-db/pom.xml 0cda1e2
>
> Diff: https://reviews.apache.org/r/21305/diff/
>
>
> Testing
> -------
>
> Manually test Sentry service and tool invocation. Also tested with schemaTool from the SENTRY-193 proposed patch with this change.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 21305: SENTRY-194: Sentry script should note use Hive
script by default for service and tool execution
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21305/
-----------------------------------------------------------
(Updated May 12, 2014, 10:51 p.m.)
Review request for sentry, Jarek Cecho and Sravya Tirukkovalur.
Changes
-------
Removed the hadoop jars from Sentry tarball
Bugs: SENTRY-194
https://issues.apache.org/jira/browse/SENTRY-194
Repository: sentry
Description
-------
Invoke Hadoop script from sentry script when possible.
Also removed the some of the Hadoop and Hive jars from Sentry distribution
Diffs (updated)
-----
bin/sentry 0bd37e8
sentry-binding/sentry-binding-hive/pom.xml 2ce4d87
sentry-binding/sentry-binding-solr/pom.xml 4ed491a
sentry-dist/src/main/assembly/bin.xml 8d9d753
sentry-dist/src/main/assembly/src.xml 208d455
sentry-policy/sentry-policy-db/pom.xml 59498f3
sentry-policy/sentry-policy-search/pom.xml 55ea3c1
sentry-provider/sentry-provider-common/pom.xml 7c17950
sentry-provider/sentry-provider-db/pom.xml 0cda1e2
sentry-provider/sentry-provider-file/pom.xml 60c4836
Diff: https://reviews.apache.org/r/21305/diff/
Testing
-------
Manually test Sentry service and tool invocation. Also tested with schemaTool from the SENTRY-193 proposed patch with this change.
Thanks,
Prasad Mujumdar
Re: Review Request 21305: SENTRY-194: Sentry script should note use Hive
script by default for service and tool execution
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21305/
-----------------------------------------------------------
(Updated May 12, 2014, 5:19 p.m.)
Review request for sentry, Jarek Cecho and Sravya Tirukkovalur.
Changes
-------
Separate out the service specific dependencies in a separate directory of the distribution. This avoids conflicts for downstream projects like hive when loading jars from Sentry lib.
Bugs: SENTRY-194
https://issues.apache.org/jira/browse/SENTRY-194
Repository: sentry
Description
-------
Invoke Hadoop script from sentry script when possible.
Also removed the some of the Hadoop and Hive jars from Sentry distribution
Diffs (updated)
-----
bin/sentry 0bd37e8
sentry-binding/sentry-binding-hive/pom.xml 2ce4d87
sentry-dist/src/main/assembly/bin.xml 8d9d753
sentry-dist/src/main/assembly/src.xml 208d455
sentry-provider/sentry-provider-db/pom.xml 0cda1e2
Diff: https://reviews.apache.org/r/21305/diff/
Testing
-------
Manually test Sentry service and tool invocation. Also tested with schemaTool from the SENTRY-193 proposed patch with this change.
Thanks,
Prasad Mujumdar