[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #629: GEODE-8364: Change log level at runtime

[GitBox <gi...@apache.org>]

pdxcodemonkey commented on a change in pull request #629:
URL: https://github.com/apache/geode-native/pull/629#discussion_r456634323



##########
File path: cppcache/test/CacheTest.cpp
##########
@@ -61,3 +62,10 @@ TEST(CacheTest, close) {
   EXPECT_THROW(cache.readyForEvents(), CacheClosedException);
   EXPECT_THROW(cache.rootRegions(), CacheClosedException);
 }
+
+TEST(CacheTest, changeLogLevel) {
+  auto cache = CacheFactory{}.set("log-level", "info").create();
+  ASSERT_EQ(cache.getLogLevel(), LogLevel::Info);

Review comment:
       Exactly - I was thinking about this earlier this morning.  We can still get into the kind of weird situation where the `geode.properties` file says `log-level` is one value but in fact it's another, and the `SystemProperties` object is also in disagreement about `log-level`.  I don't think the first situation is worth worrying about - unless I'm very mistaken, you'll be in this state even when you set `log-level` on the cache factory to a custom value.  The second, however, it seems to me we should be able to prevent.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org