You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "eugenegujing (via GitHub)" <gi...@apache.org> on 2026/08/19 00:25:47 UTC
[PR] test(workflow-operator): extend tests to cover the Projection drop mode [texera]
eugenegujing opened a new pull request, #7767:
URL: https://github.com/apache/texera/pull/7767
### What changes were proposed in this PR?
The Projection operator's "Drop Option" (`isDrop`) inverts what the operator does: with it on, the listed attributes are removed and every other attribute is kept under its original name, with aliases ignored. Both the runtime tuple rewrite (`ProjectionOpExec`) and the compile-time output-schema derivation (`ProjectionOpDesc`) branch on this flag, but all 19 existing Projection tests leave it at its `false` default, so the entire drop half ran uncovered.
This PR adds 14 tests, all with `isDrop = true`, and changes no production code. `ProjectionOpExecSpec` gains 8 tests: dropping one and multiple attributes, aliases being ignored, dropping a non-existent attribute, dropping every attribute, exec output matching the descriptor-derived schema for the same config, case-sensitive name matching, and duplicate drop entries. `ProjectionOpDescSpec` gains 6 mirror tests on the schema-derivation side: remaining names/types/order, aliases ignored, non-existent attribute, dropping everything, case-insensitive matching, and duplicate entries.
The degenerate-case tests pin three exec-vs-descriptor asymmetries as they exist today rather than fixing them, since unifying them is a behavior decision for a separate issue: unknown names (the exec's `diff`-based rewrite silently ignores them, `Schema.remove` throws `IllegalArgumentException`), case handling (the exec matches exactly and keeps a column the descriptor-derived schema says was dropped, with no error on either side), and duplicate entries (the exec tolerates them, the descriptor throws). Each side's test carries a comment pointing at the other side of the asymmetry.
### Any related issues, documentation, discussions?
Resolves #7765
### How was this PR tested?
This PR is test-only. Both suites pass locally: `sbt "WorkflowOperator/testOnly *ProjectionOpExecSpec *ProjectionOpDescSpec"` runs 33 tests (19 pre-existing + 14 new), all green, and `WorkflowOperator/Test/scalafmtCheck` passes. The full `WorkflowOperator/test` suite was also run locally to confirm the new tests introduce no cross-test interference.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Fable 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): extend tests to cover the Projection drop mode [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7767:
URL: https://github.com/apache/texera/pull/7767#issuecomment-5335977275
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7767?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 91.02%. Comparing base ([`fb9f4e2`](https://app.codecov.io/gh/apache/texera/commit/fb9f4e26d8680ebeb3da28881b27707645d59acd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a383032`](https://app.codecov.io/gh/apache/texera/commit/a3830322dd0d918bd412f642e5488688503a6ad3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #7767 +/- ##
=========================================
Coverage 91.02% 91.02%
Complexity 4454 4454
=========================================
Files 1174 1174
Lines 47146 47146
Branches 5287 5287
=========================================
Hits 42915 42915
Misses 2551 2551
Partials 1680 1680
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/7767/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/7767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.62% <ø> (ø)` | | Carriedforward from [fb9f4e2](https://app.codecov.io/gh/apache/texera/commit/fb9f4e26d8680ebeb3da28881b27707645d59acd?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/7767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.45% <ø> (ø)` | | Carriedforward from [fb9f4e2](https://app.codecov.io/gh/apache/texera/commit/fb9f4e26d8680ebeb3da28881b27707645d59acd?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [fb9f4e2](https://app.codecov.io/gh/apache/texera/commit/fb9f4e26d8680ebeb3da28881b27707645d59acd?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/7767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.73% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/7767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `68.90% <ø> (ø)` | | Carriedforward from [fb9f4e2](https://app.codecov.io/gh/apache/texera/commit/fb9f4e26d8680ebeb3da28881b27707645d59acd?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/7767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `92.59% <ø> (ø)` | | Carriedforward from [fb9f4e2](https://app.codecov.io/gh/apache/texera/commit/fb9f4e26d8680ebeb3da28881b27707645d59acd?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.74% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/7767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `97.57% <ø> (ø)` | | Carriedforward from [fb9f4e2](https://app.codecov.io/gh/apache/texera/commit/fb9f4e26d8680ebeb3da28881b27707645d59acd?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [fb9f4e2](https://app.codecov.io/gh/apache/texera/commit/fb9f4e26d8680ebeb3da28881b27707645d59acd?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7767?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): extend tests to cover the Projection drop mode [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7767:
URL: https://github.com/apache/texera/pull/7767#issuecomment-5335996986
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 4 better · 🔴 1 worse · ⚪ 10 noise (<±5%) · 0 without baseline
> Compared against main `fb9f4e2` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/32201210474)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 411 | 0.251 | 23,557/30,651/30,651 us | 🟢 -28.8% / 🔴 +89.0% |
| 🟢 | bs=100 sw=10 sl=64 | 798 | 0.487 | 124,622/146,738/146,738 us | 🟢 -8.6% / 🔴 +32.2% |
| ⚪ | bs=1000 sw=10 sl=64 | 901 | 0.55 | 1,107,737/1,191,695/1,191,695 us | ⚪ within ±5% / 🔴 +12.9% |
<details><summary>Baseline details</summary>
Latest main `fb9f4e2` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 411 tuples/sec | 408 tuples/sec | 743.3 tuples/sec | +0.7% | -44.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.251 MB/s | 0.249 MB/s | 0.454 MB/s | +0.8% | -44.7% |
| bs=10 sw=10 sl=64 | p50 | 23,557 us | 19,869 us | 13,204 us | +18.6% | +78.4% |
| bs=10 sw=10 sl=64 | p95 | 30,651 us | 43,024 us | 16,220 us | -28.8% | +89.0% |
| bs=10 sw=10 sl=64 | p99 | 30,651 us | 43,024 us | 19,867 us | -28.8% | +54.3% |
| bs=100 sw=10 sl=64 | throughput | 798 tuples/sec | 779 tuples/sec | 959.52 tuples/sec | +2.4% | -16.8% |
| bs=100 sw=10 sl=64 | MB/s | 0.487 MB/s | 0.476 MB/s | 0.586 MB/s | +2.3% | -16.8% |
| bs=100 sw=10 sl=64 | p50 | 124,622 us | 126,614 us | 103,974 us | -1.6% | +19.9% |
| bs=100 sw=10 sl=64 | p95 | 146,738 us | 160,524 us | 111,036 us | -8.6% | +32.2% |
| bs=100 sw=10 sl=64 | p99 | 146,738 us | 160,524 us | 118,982 us | -8.6% | +23.3% |
| bs=1000 sw=10 sl=64 | throughput | 901 tuples/sec | 924 tuples/sec | 994.68 tuples/sec | -2.5% | -9.4% |
| bs=1000 sw=10 sl=64 | MB/s | 0.55 MB/s | 0.564 MB/s | 0.607 MB/s | -2.5% | -9.4% |
| bs=1000 sw=10 sl=64 | p50 | 1,107,737 us | 1,081,808 us | 1,011,206 us | +2.4% | +9.5% |
| bs=1000 sw=10 sl=64 | p95 | 1,191,695 us | 1,137,640 us | 1,055,603 us | +4.8% | +12.9% |
| bs=1000 sw=10 sl=64 | p99 | 1,191,695 us | 1,137,640 us | 1,084,808 us | +4.8% | +9.9% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,486.44,200,128000,411,0.251,23556.96,30650.72,30650.72
1,100,10,64,20,2507.64,2000,1280000,798,0.487,124621.69,146737.89,146737.89
2,1000,10,64,20,22196.01,20000,12800000,901,0.550,1107736.63,1191694.96,1191694.96
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): extend tests to cover the Projection drop mode [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #7767:
URL: https://github.com/apache/texera/pull/7767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): extend tests to cover the Projection drop mode [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7767:
URL: https://github.com/apache/texera/pull/7767#issuecomment-5335955971
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@aglinxinyuan`, `@Yicong-Huang`
You can notify them by mentioning `@aglinxinyuan`, `@Yicong-Huang` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org