(superset) branch test-ci updated: Revert "fix(ci): Docker master builds fail while checking version (#27087)"

[mi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a commit to branch test-ci
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/test-ci by this push:
     new 9695781fdb Revert "fix(ci): Docker master builds fail while checking version (#27087)"
9695781fdb is described below

commit 9695781fdb39a8e41065fffd8c5b528ba5bf8fe6
Author: Michael S. Molina <mi...@gmail.com>
AuthorDate: Mon Mar 4 15:03:10 2024 -0500

    Revert "fix(ci): Docker master builds fail while checking version (#27087)"
    
    This reverts commit 8bee6edc478ba11afab57c8b8791a12f08b447cb.
---
 scripts/build_docker.py | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/scripts/build_docker.py b/scripts/build_docker.py
index 13453b61f9..aac5129d80 100755
--- a/scripts/build_docker.py
+++ b/scripts/build_docker.py
@@ -28,7 +28,7 @@ CACHE_REPO = f"{REPO}-cache"
 BASE_PY_IMAGE = "3.9-slim-bookworm"
 
 
-def run_cmd(command: str, raise_on_failure: bool = True) -> str:
+def run_cmd(command: str) -> str:
     process = subprocess.Popen(
         command, shell=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, text=True
     )
@@ -41,8 +41,9 @@ def run_cmd(command: str, raise_on_failure: bool = True) -> str:
 
     process.wait()  # Wait for the subprocess to finish
 
-    if process.returncode != 0 and raise_on_failure:
+    if process.returncode != 0:
         raise subprocess.CalledProcessError(process.returncode, command, output)
+
     return output
 
 
@@ -72,13 +73,7 @@ def get_build_context_ref(build_context: str) -> str:
 
 
 def is_latest_release(release: str) -> bool:
-    output = (
-        run_cmd(
-            f"./scripts/tag_latest_release.sh {release} --dry-run",
-            raise_on_failure=False,
-        )
-        or ""
-    )
+    output = run_cmd(f"./scripts/tag_latest_release.sh {release} --dry-run") or ""
     return "SKIP_TAG::false" in output