You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "fallintoplace (via GitHub)" <gi...@apache.org> on 2026/08/05 22:13:12 UTC
[PR] fix(arrow/scalar): release partial struct conversions [arrow-go]
fallintoplace opened a new pull request, #1114:
URL: https://github.com/apache/arrow-go/pull/1114
ToScalar keeps child scalars created before a later struct field returns an error. This leaks array-backed child values on failed conversions.
Release partial children unless ownership has been transferred to the completed struct scalar and add checked-allocator coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(arrow/scalar): release partial children after failed struct conversion [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #1114:
URL: https://github.com/apache/arrow-go/pull/1114#issuecomment-5243278562
@fallintoplace Heads-up: [#1106](https://github.com/apache/arrow-go/pull/1106) has just been merged into `main`. It touches the same `arrow/scalar/` code as this PR, so GitHub now reports this branch as conflicting.
Nothing is wrong with this PR — it is still approved. It just needs a rebase onto the latest `main` to resolve the overlap, and then it can go in.
Apologies for the extra round-trip: the conflict is a side effect of the sibling fix landing first, not anything you did.
---
_Note: This comment was drafted by an AI-assisted triage tool run by a maintainer, and may contain mistakes. Once you have addressed the points above, an Apache Arrow Go maintainer — a real person — will take the next look at your PR. If anything here looks wrong, say so on the PR and a maintainer will follow up. See [CONTRIBUTING.md](https://github.com/apache/arrow-go/blob/main/CONTRIBUTING.md) for the project's contribution conventions._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(arrow/scalar): release partial children after failed struct conversion [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1114:
URL: https://github.com/apache/arrow-go/pull/1114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org