You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2010/03/15 14:58:27 UTC
[jira] Created: (SOLR-1824) partial field types created on error
partial field types created on error
------------------------------------
Key: SOLR-1824
URL: https://issues.apache.org/jira/browse/SOLR-1824
Project: Solr
Issue Type: Bug
Affects Versions: 1.1.0
Reporter: Yonik Seeley
Priority: Minor
When abortOnConfigurationError=false, and there is a typo in one of the filters in a chain, the field type is still created by omitting that particular filter. This is particularly dangerous since it will result in incorrect indexing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1824) partial field types created on error
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845319#action_12845319 ]
Yonik Seeley commented on SOLR-1824:
------------------------------------
The partial field is created regardless of abortOnConfigurationError... it's just more serious when it's false and things may look OK.
> partial field types created on error
> ------------------------------------
>
> Key: SOLR-1824
> URL: https://issues.apache.org/jira/browse/SOLR-1824
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Yonik Seeley
> Priority: Minor
>
> When abortOnConfigurationError=false, and there is a typo in one of the filters in a chain, the field type is still created by omitting that particular filter. This is particularly dangerous since it will result in incorrect indexing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1824) partial field types created on error
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845419#action_12845419 ]
Uwe Schindler commented on SOLR-1824:
-------------------------------------
It should be easy to fix. The init() method in the AbstractPluginLoader anonymous class checks for plugin!=null. In the null case it should throw exception to make the whole loadAnalyzer() call invalid, what makes the field type disappear.
> partial field types created on error
> ------------------------------------
>
> Key: SOLR-1824
> URL: https://issues.apache.org/jira/browse/SOLR-1824
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Yonik Seeley
> Priority: Minor
>
> When abortOnConfigurationError=false, and there is a typo in one of the filters in a chain, the field type is still created by omitting that particular filter. This is particularly dangerous since it will result in incorrect indexing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1824) partial field types created on error
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847166#action_12847166 ]
Hoss Man commented on SOLR-1824:
--------------------------------
Scratch that -- i get it now:
* IndexSchem uses anonymous subclasses of AbstractPluginLoader to instantiate a variety of differnet things
* AbstractPluginLoader processes things in a loop, recording errors in SolrConfig.severeErrors when a particular instance can't be inited, but creating the rest of the objects just fine.
* when abortOnConfigurationError=false this results in solr using a schema with missing filters (or missing fields, etc...) .. the only thing that protects people when abortOnConfigurationError=true is that SolrDispatchFilter pays attention to both abortOnConfigurationError and SolrConfig.severeErrors (someone using embedded Solr might never notice the error at all, even if the config did say abortOnConfigurationError=true)
> partial field types created on error
> ------------------------------------
>
> Key: SOLR-1824
> URL: https://issues.apache.org/jira/browse/SOLR-1824
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Yonik Seeley
> Priority: Minor
>
> When abortOnConfigurationError=false, and there is a typo in one of the filters in a chain, the field type is still created by omitting that particular filter. This is particularly dangerous since it will result in incorrect indexing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1824) partial field types created on error
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846235#action_12846235 ]
Hoss Man commented on SOLR-1824:
--------------------------------
Can someone point me to a method name and/or line number? ... i'm not following what exactly is the current bug.
(particularly with regards to abortOnConfigurationError=false ... nothing in IndexSchema has ever looked at that config option, so if it has any problem initing a field/fieldtype it should be throwing an exception and completly failing to initialize -- so i don't see how the problem could be any better/worse depending on the value of that option)
> partial field types created on error
> ------------------------------------
>
> Key: SOLR-1824
> URL: https://issues.apache.org/jira/browse/SOLR-1824
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Yonik Seeley
> Priority: Minor
>
> When abortOnConfigurationError=false, and there is a typo in one of the filters in a chain, the field type is still created by omitting that particular filter. This is particularly dangerous since it will result in incorrect indexing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.