You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/03/26 00:54:10 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #3666: Better control what we manage in our BOM
ppalaga opened a new pull request #3666:
URL: https://github.com/apache/camel-quarkus/pull/3666
Fix #3302
This fixes issues 1, 2, 3, 4.1 and 5 of #3302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #3666: Better control what we manage in our BOM
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #3666:
URL: https://github.com/apache/camel-quarkus/pull/3666#issuecomment-1081095382
> While looking at the `poms/bom/src/main/generated/flattened-reduced-pom.xml`, it looks that the version is the same with a given `groupId` except near the end of the file for:
>
> * com.azure
> * com.microsoft.azure
I checked in `flattened-reduced-verbose-pom.xml` where each entry has a comment saying which original bom it comes from.
And all `com.azure:*` and `com.microsoft.azure:*` come from the same `com.azure:azure-sdk-bom:1.0.5`
So the different versions should be fine.
> * com.datastax.oss
Similar: they are from `com.datastax.oss.quarkus:cassandra-quarkus-bom:1.1.2` and the transitively imported `com.datastax.oss:java-driver-bom:4.14.0`
> * com.hazelcast
Same: `com.hazelcast:quarkus-hazelcast-client-bom:3.0.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3666: Better control what we manage in our BOM
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3666:
URL: https://github.com/apache/camel-quarkus/pull/3666#issuecomment-1080819051
While looking at the `poms/bom/src/main/generated/flattened-reduced-pom.xml`, it looks that the version is the same with a given `groupId` except near the end of the file for:
+ com.azure
+ com.microsoft.azure
+ com.datastax.oss
+ com.hazelcast
Is there cases where it is not possible/needed to align ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #3666: Better control what we manage in our BOM
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #3666:
URL: https://github.com/apache/camel-quarkus/pull/3666#issuecomment-1080328212
In between I could perhaps try to test this in 2.7.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #3666: Better control what we manage in our BOM
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #3666:
URL: https://github.com/apache/camel-quarkus/pull/3666#issuecomment-1080357695
Camel 3.16 seems to be in Central now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #3666: Better control what we manage in our BOM
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #3666:
URL: https://github.com/apache/camel-quarkus/pull/3666#discussion_r836389502
##########
File path: extensions-support/azure-core-http-client-vertx/deployment/pom.xml
##########
@@ -101,11 +101,6 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>io.projectreactor</groupId>
- <artifactId>reactor-test</artifactId>
- <scope>test</scope>
- </dependency>
Review comment:
Yes, probably a leftover. The test suite seems to run ok without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #3666: Better control what we manage in our BOM
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #3666:
URL: https://github.com/apache/camel-quarkus/pull/3666#issuecomment-1079889106
853b5b7 :
* FHIR libs are back
* Kafka connect-runtime is back
Probably still not perfect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #3666: Better control what we manage in our BOM
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #3666:
URL: https://github.com/apache/camel-quarkus/pull/3666#issuecomment-1079624020
> I am not quite sure about the many FHIR jars, that were eliminated. I wonder whether we should whitelist them?
For now, whitelist them. We can think about making some of them optional in the Camel component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #3666: Better control what we manage in our BOM
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #3666:
URL: https://github.com/apache/camel-quarkus/pull/3666#issuecomment-1080319948
Ah the Camel 3.16 staging repo does not exist anymore and the artifacts were still not synced to central :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #3666: Better control what we manage in our BOM
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #3666:
URL: https://github.com/apache/camel-quarkus/pull/3666#discussion_r836381193
##########
File path: extensions-support/azure-core-http-client-vertx/deployment/pom.xml
##########
@@ -101,11 +101,6 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>io.projectreactor</groupId>
- <artifactId>reactor-test</artifactId>
- <scope>test</scope>
- </dependency>
Review comment:
This does not seem to be required. Is it really a leftover from some experiments, @jamesnetherton?
Otherwise I'd have to find a way how to manage the version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #3666: Better control what we manage in our BOM
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #3666:
URL: https://github.com/apache/camel-quarkus/pull/3666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org