You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2016/12/18 08:10:41 UTC
svn commit: r1774856 -
/subversion/branches/authzperf/subversion/tests/libsvn_repos/repos-test.c
Author: stefan2
Date: Sun Dec 18 08:10:41 2016
New Revision: 1774856
URL: http://svn.apache.org/viewvc?rev=1774856&view=rev
Log:
On the authzperf branch:
Fix a pool lifetime issue in our config pool tests. The issue would only
be triggered when there is a test failure.
* subversion/tests/libsvn_repos/repos-test.c
(test_config_pool): The config pool needs to live at least as long as
the references to its content, thus these may not
be allocated from sibling pools. Same or sub-pool
would be fine.
Modified:
subversion/branches/authzperf/subversion/tests/libsvn_repos/repos-test.c
Modified: subversion/branches/authzperf/subversion/tests/libsvn_repos/repos-test.c
URL: http://svn.apache.org/viewvc/subversion/branches/authzperf/subversion/tests/libsvn_repos/repos-test.c?rev=1774856&r1=1774855&r2=1774856&view=diff
==============================================================================
--- subversion/branches/authzperf/subversion/tests/libsvn_repos/repos-test.c (original)
+++ subversion/branches/authzperf/subversion/tests/libsvn_repos/repos-test.c Sun Dec 18 08:10:41 2016
@@ -3876,18 +3876,14 @@ test_config_pool(const svn_test_opts_t *
svn_error_t *err;
svn_repos__config_pool_t *config_pool;
- apr_pool_t *config_pool_pool;
apr_pool_t *subpool = svn_pool_create(pool);
const char *wrk_dir = svn_test_data_path("config_pool", pool);
SVN_ERR(svn_io_make_dir_recursively(wrk_dir, pool));
- /* read all config info through a single config pool and we want to be
- able to control its lifetime. The latter requires a separate pool. */
- config_pool_pool = svn_pool_create(pool);
- SVN_ERR(svn_repos__config_pool_create(&config_pool, TRUE,
- config_pool_pool));
+ /* read all config info through a single config pool. */
+ SVN_ERR(svn_repos__config_pool_create(&config_pool, TRUE, pool));
/* have two different configurations */
SVN_ERR(svn_test_get_srcdir(&srcdir, opts, pool));