You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Andreas Sahlbach (JIRA)" <ji...@apache.org> on 2012/10/24 15:58:12 UTC

[jira] [Created] (DIGESTER-174) Inner List Annotation has wrong @Target for most of the predefined annotation rules

Andreas Sahlbach created DIGESTER-174:
-----------------------------------------

             Summary: Inner List Annotation has wrong @Target for most of the predefined annotation rules
                 Key: DIGESTER-174
                 URL: https://issues.apache.org/jira/browse/DIGESTER-174
             Project: Commons Digester
          Issue Type: Bug
    Affects Versions: 3.2
            Reporter: Andreas Sahlbach


See documentation "Applying multiple annotation rule of the same type"
The inner annotation should be usable as a wrapper for the outer annotation, to apply several rules to one element. Therefore the inner annotation has to have the very same defined @Target annotations as the outer annotation. This is not the case for most of the rules, making them practically useless. 
Example:
@BeanPropertySetter - its @Target is ElementType.Field
but its inner List 
@BeanPropertySetter.List - its @Target is ElementType.Type
The only place where this is correct are the Create Rules, which are the annotations from the documentation.
May I suggest to create a test case or example for a multi annotation rule? The provided example was very helpful for me, but is very simple.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (DIGESTER-174) Inner List Annotation has wrong @Target for most of the predefined annotation rules

Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIGESTER-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486853#comment-13486853 ] 

Simone Tripodi commented on DIGESTER-174:
-----------------------------------------

Good catch Andreas,

would you provide a patch to fix that issue? Patches are welcome and people are invited on taking participation in the development - just submit a patch to JIRA and I will be more than pleased to apply it!

Many thanks in advance,
-Simo
                
> Inner List Annotation has wrong @Target for most of the predefined annotation rules
> -----------------------------------------------------------------------------------
>
>                 Key: DIGESTER-174
>                 URL: https://issues.apache.org/jira/browse/DIGESTER-174
>             Project: Commons Digester
>          Issue Type: Bug
>    Affects Versions: 3.2
>            Reporter: Andreas Sahlbach
>
> See documentation "Applying multiple annotation rule of the same type"
> The inner annotation should be usable as a wrapper for the outer annotation, to apply several rules to one element. Therefore the inner annotation has to have the very same defined {{@Target}} annotations as the outer annotation. This is not the case for most of the rules, making them practically useless. 
> Example:
> {{@BeanPropertySetter}} - its {{@Target}} is {{ElementType.Field}}
> but its inner List 
> {{@BeanPropertySetter.List}} - its {{@Target}} is {{ElementType.Type}}
> The only place where this is correct are the Create Rules, which are the annotations from the documentation.
> May I suggest to create a test case or example for a multi annotation rule? The provided example for annotated rules was very helpful for me, but is very simple and doesn't cover multi annotated rules.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (DIGESTER-174) Inner List Annotation has wrong @Target for most of the predefined annotation rules

Posted by "Andreas Sahlbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIGESTER-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Sahlbach updated DIGESTER-174:
--------------------------------------

    Description: 
See documentation "Applying multiple annotation rule of the same type"
The inner annotation should be usable as a wrapper for the outer annotation, to apply several rules to one element. Therefore the inner annotation has to have the very same defined @Target annotations as the outer annotation. This is not the case for most of the rules, making them practically useless. 
Example:
@BeanPropertySetter - its @Target is ElementType.Field
but its inner List 
@BeanPropertySetter.List - its @Target is ElementType.Type
The only place where this is correct are the Create Rules, which are the annotations from the documentation.
May I suggest to create a test case or example for a multi annotation rule? The provided example for annotated rules was very helpful for me, but is very simple and doesn't cover multi annotated rules.

  was:
See documentation "Applying multiple annotation rule of the same type"
The inner annotation should be usable as a wrapper for the outer annotation, to apply several rules to one element. Therefore the inner annotation has to have the very same defined @Target annotations as the outer annotation. This is not the case for most of the rules, making them practically useless. 
Example:
@BeanPropertySetter - its @Target is ElementType.Field
but its inner List 
@BeanPropertySetter.List - its @Target is ElementType.Type
The only place where this is correct are the Create Rules, which are the annotations from the documentation.
May I suggest to create a test case or example for a multi annotation rule? The provided example for annotated rules was very helpful for me, but is very simple and doesn't cover the multi annotated rules.

    
> Inner List Annotation has wrong @Target for most of the predefined annotation rules
> -----------------------------------------------------------------------------------
>
>                 Key: DIGESTER-174
>                 URL: https://issues.apache.org/jira/browse/DIGESTER-174
>             Project: Commons Digester
>          Issue Type: Bug
>    Affects Versions: 3.2
>            Reporter: Andreas Sahlbach
>
> See documentation "Applying multiple annotation rule of the same type"
> The inner annotation should be usable as a wrapper for the outer annotation, to apply several rules to one element. Therefore the inner annotation has to have the very same defined @Target annotations as the outer annotation. This is not the case for most of the rules, making them practically useless. 
> Example:
> @BeanPropertySetter - its @Target is ElementType.Field
> but its inner List 
> @BeanPropertySetter.List - its @Target is ElementType.Type
> The only place where this is correct are the Create Rules, which are the annotations from the documentation.
> May I suggest to create a test case or example for a multi annotation rule? The provided example for annotated rules was very helpful for me, but is very simple and doesn't cover multi annotated rules.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (DIGESTER-174) Inner List Annotation has wrong @Target for most of the predefined annotation rules

Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIGESTER-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi resolved DIGESTER-174.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 3.3
         Assignee: Simone Tripodi

Fixed on [r1406102|http://svn.apache.org/viewvc?rev=1406102&view=rev], feel free to add more testcases and provide a patch!
                
> Inner List Annotation has wrong @Target for most of the predefined annotation rules
> -----------------------------------------------------------------------------------
>
>                 Key: DIGESTER-174
>                 URL: https://issues.apache.org/jira/browse/DIGESTER-174
>             Project: Commons Digester
>          Issue Type: Bug
>    Affects Versions: 3.2
>            Reporter: Andreas Sahlbach
>            Assignee: Simone Tripodi
>             Fix For: 3.3
>
>
> See documentation "Applying multiple annotation rule of the same type"
> The inner annotation should be usable as a wrapper for the outer annotation, to apply several rules to one element. Therefore the inner annotation has to have the very same defined {{@Target}} annotations as the outer annotation. This is not the case for most of the rules, making them practically useless. 
> Example:
> {{@BeanPropertySetter}} - its {{@Target}} is {{ElementType.Field}}
> but its inner List 
> {{@BeanPropertySetter.List}} - its {{@Target}} is {{ElementType.Type}}
> The only place where this is correct are the Create Rules, which are the annotations from the documentation.
> May I suggest to create a test case or example for a multi annotation rule? The provided example for annotated rules was very helpful for me, but is very simple and doesn't cover multi annotated rules.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (DIGESTER-174) Inner List Annotation has wrong @Target for most of the predefined annotation rules

Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIGESTER-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi updated DIGESTER-174:
------------------------------------

    Description: 
See documentation "Applying multiple annotation rule of the same type"
The inner annotation should be usable as a wrapper for the outer annotation, to apply several rules to one element. Therefore the inner annotation has to have the very same defined {{@Target}} annotations as the outer annotation. This is not the case for most of the rules, making them practically useless. 
Example:
{{@BeanPropertySetter}} - its {{@Target}} is {{ElementType.Field}}
but its inner List 
{{@BeanPropertySetter.List}} - its {{@Target}} is {{ElementType.Type}}
The only place where this is correct are the Create Rules, which are the annotations from the documentation.
May I suggest to create a test case or example for a multi annotation rule? The provided example for annotated rules was very helpful for me, but is very simple and doesn't cover multi annotated rules.

  was:
See documentation "Applying multiple annotation rule of the same type"
The inner annotation should be usable as a wrapper for the outer annotation, to apply several rules to one element. Therefore the inner annotation has to have the very same defined @Target annotations as the outer annotation. This is not the case for most of the rules, making them practically useless. 
Example:
@BeanPropertySetter - its @Target is ElementType.Field
but its inner List 
@BeanPropertySetter.List - its @Target is ElementType.Type
The only place where this is correct are the Create Rules, which are the annotations from the documentation.
May I suggest to create a test case or example for a multi annotation rule? The provided example for annotated rules was very helpful for me, but is very simple and doesn't cover multi annotated rules.

    
> Inner List Annotation has wrong @Target for most of the predefined annotation rules
> -----------------------------------------------------------------------------------
>
>                 Key: DIGESTER-174
>                 URL: https://issues.apache.org/jira/browse/DIGESTER-174
>             Project: Commons Digester
>          Issue Type: Bug
>    Affects Versions: 3.2
>            Reporter: Andreas Sahlbach
>
> See documentation "Applying multiple annotation rule of the same type"
> The inner annotation should be usable as a wrapper for the outer annotation, to apply several rules to one element. Therefore the inner annotation has to have the very same defined {{@Target}} annotations as the outer annotation. This is not the case for most of the rules, making them practically useless. 
> Example:
> {{@BeanPropertySetter}} - its {{@Target}} is {{ElementType.Field}}
> but its inner List 
> {{@BeanPropertySetter.List}} - its {{@Target}} is {{ElementType.Type}}
> The only place where this is correct are the Create Rules, which are the annotations from the documentation.
> May I suggest to create a test case or example for a multi annotation rule? The provided example for annotated rules was very helpful for me, but is very simple and doesn't cover multi annotated rules.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (DIGESTER-174) Inner List Annotation has wrong @Target for most of the predefined annotation rules

Posted by "Andreas Sahlbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIGESTER-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Sahlbach updated DIGESTER-174:
--------------------------------------

    Description: 
See documentation "Applying multiple annotation rule of the same type"
The inner annotation should be usable as a wrapper for the outer annotation, to apply several rules to one element. Therefore the inner annotation has to have the very same defined @Target annotations as the outer annotation. This is not the case for most of the rules, making them practically useless. 
Example:
@BeanPropertySetter - its @Target is ElementType.Field
but its inner List 
@BeanPropertySetter.List - its @Target is ElementType.Type
The only place where this is correct are the Create Rules, which are the annotations from the documentation.
May I suggest to create a test case or example for a multi annotation rule? The provided example for annotated rules was very helpful for me, but is very simple and doesn't cover the multi annotated rules.

  was:
See documentation "Applying multiple annotation rule of the same type"
The inner annotation should be usable as a wrapper for the outer annotation, to apply several rules to one element. Therefore the inner annotation has to have the very same defined @Target annotations as the outer annotation. This is not the case for most of the rules, making them practically useless. 
Example:
@BeanPropertySetter - its @Target is ElementType.Field
but its inner List 
@BeanPropertySetter.List - its @Target is ElementType.Type
The only place where this is correct are the Create Rules, which are the annotations from the documentation.
May I suggest to create a test case or example for a multi annotation rule? The provided example was very helpful for me, but is very simple.

    
> Inner List Annotation has wrong @Target for most of the predefined annotation rules
> -----------------------------------------------------------------------------------
>
>                 Key: DIGESTER-174
>                 URL: https://issues.apache.org/jira/browse/DIGESTER-174
>             Project: Commons Digester
>          Issue Type: Bug
>    Affects Versions: 3.2
>            Reporter: Andreas Sahlbach
>
> See documentation "Applying multiple annotation rule of the same type"
> The inner annotation should be usable as a wrapper for the outer annotation, to apply several rules to one element. Therefore the inner annotation has to have the very same defined @Target annotations as the outer annotation. This is not the case for most of the rules, making them practically useless. 
> Example:
> @BeanPropertySetter - its @Target is ElementType.Field
> but its inner List 
> @BeanPropertySetter.List - its @Target is ElementType.Type
> The only place where this is correct are the Create Rules, which are the annotations from the documentation.
> May I suggest to create a test case or example for a multi annotation rule? The provided example for annotated rules was very helpful for me, but is very simple and doesn't cover the multi annotated rules.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira