You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ca...@apache.org on 2006/06/21 00:55:06 UTC
svn commit: r415834 -
/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
Author: carlos
Date: Tue Jun 20 15:55:05 2006
New Revision: 415834
URL: http://svn.apache.org/viewvc?rev=415834&view=rev
Log:
Use more realistic maven rules
Modified:
maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml?rev=415834&r1=415833&r2=415834&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml Tue Jun 20 15:55:05 2006
@@ -62,9 +62,13 @@
<!-- Checks for Javadoc comments. -->
<!-- See http://checkstyle.sf.net/config_javadoc.html -->
- <module name="JavadocMethod"/>
+ <module name="JavadocMethod">
+ <property name="severity" value="warning"/>
+ </module>
<module name="JavadocType"/>
- <module name="JavadocVariable"/>
+ <module name="JavadocVariable">
+ <property name="severity" value="info"/>
+ </module>
<!-- Checks for Naming Conventions. -->
@@ -134,7 +138,9 @@
<module name="DoubleCheckedLocking"/>
<module name="EmptyStatement"/>
<module name="EqualsHashCode"/>
- <module name="HiddenField"/>
+ <module name="HiddenField">
+ <property name="severity" value="warning"/>
+ </module>
<module name="IllegalInstantiation"/>
<module name="InnerAssignment"/>
<module name="MagicNumber"/>
Re: svn commit: r415834 - /maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
Posted by Carlos Sanchez <ca...@apache.org>.
both ;) I thought about that too.
On 6/21/06, Brett Porter <br...@apache.org> wrote:
> Are you changing these because you think these are the best final value,
> or because the current code isn't close to complying?
>
> If it's the former, that's cool; if it's the latter I'd suggest we
> should keep the checkstyle plugin in the "ideal" configuration, and
> override it in Maven itself.
>
> - Brett
>
> On 21/06/2006 8:55 AM, carlos@apache.org wrote:
> > Author: carlos
> > Date: Tue Jun 20 15:55:05 2006
> > New Revision: 415834
> >
> > URL: http://svn.apache.org/viewvc?rev=415834&view=rev
> > Log:
> > Use more realistic maven rules
> >
> > Modified:
> > maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
> >
> > Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
> > URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml?rev=415834&r1=415833&r2=415834&view=diff
> > ==============================================================================
> > --- maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml (original)
> > +++ maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml Tue Jun 20 15:55:05 2006
> > @@ -62,9 +62,13 @@
> >
> > <!-- Checks for Javadoc comments. -->
> > <!-- See http://checkstyle.sf.net/config_javadoc.html -->
> > - <module name="JavadocMethod"/>
> > + <module name="JavadocMethod">
> > + <property name="severity" value="warning"/>
> > + </module>
> > <module name="JavadocType"/>
> > - <module name="JavadocVariable"/>
> > + <module name="JavadocVariable">
> > + <property name="severity" value="info"/>
> > + </module>
> >
> >
> > <!-- Checks for Naming Conventions. -->
> > @@ -134,7 +138,9 @@
> > <module name="DoubleCheckedLocking"/>
> > <module name="EmptyStatement"/>
> > <module name="EqualsHashCode"/>
> > - <module name="HiddenField"/>
> > + <module name="HiddenField">
> > + <property name="severity" value="warning"/>
> > + </module>
> > <module name="IllegalInstantiation"/>
> > <module name="InnerAssignment"/>
> > <module name="MagicNumber"/>
> >
> >
>
>
> --
> Brett Porter <br...@apache.org>
> Apache Maven - http://maven.apache.org/
> Better Builds with Maven - http://library.mergere.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r415834 - /maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
Posted by Brett Porter <br...@apache.org>.
Are you changing these because you think these are the best final value,
or because the current code isn't close to complying?
If it's the former, that's cool; if it's the latter I'd suggest we
should keep the checkstyle plugin in the "ideal" configuration, and
override it in Maven itself.
- Brett
On 21/06/2006 8:55 AM, carlos@apache.org wrote:
> Author: carlos
> Date: Tue Jun 20 15:55:05 2006
> New Revision: 415834
>
> URL: http://svn.apache.org/viewvc?rev=415834&view=rev
> Log:
> Use more realistic maven rules
>
> Modified:
> maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
>
> Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml?rev=415834&r1=415833&r2=415834&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml (original)
> +++ maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml Tue Jun 20 15:55:05 2006
> @@ -62,9 +62,13 @@
>
> <!-- Checks for Javadoc comments. -->
> <!-- See http://checkstyle.sf.net/config_javadoc.html -->
> - <module name="JavadocMethod"/>
> + <module name="JavadocMethod">
> + <property name="severity" value="warning"/>
> + </module>
> <module name="JavadocType"/>
> - <module name="JavadocVariable"/>
> + <module name="JavadocVariable">
> + <property name="severity" value="info"/>
> + </module>
>
>
> <!-- Checks for Naming Conventions. -->
> @@ -134,7 +138,9 @@
> <module name="DoubleCheckedLocking"/>
> <module name="EmptyStatement"/>
> <module name="EqualsHashCode"/>
> - <module name="HiddenField"/>
> + <module name="HiddenField">
> + <property name="severity" value="warning"/>
> + </module>
> <module name="IllegalInstantiation"/>
> <module name="InnerAssignment"/>
> <module name="MagicNumber"/>
>
>
--
Brett Porter <br...@apache.org>
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org