You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Ian Springer (JIRA)" <ji...@codehaus.org> on 2006/05/31 01:29:43 UTC
[jira] Created: (MWAR-45) add config prop to specify webapp classes
should be zipped and placed into WEB-INF/lib/xxx.jar instead of placed in
WEB-INF/classes/
add config prop to specify webapp classes should be zipped and placed into WEB-INF/lib/xxx.jar instead of placed in WEB-INF/classes/
-------------------------------------------------------------------------------------------------------------------------------------
Key: MWAR-45
URL: http://jira.codehaus.org/browse/MWAR-45
Project: Maven 2.x War Plugin
Type: New Feature
Versions: 2.0
Reporter: Ian Springer
I think this is a common enough practice that there should be an option provided for it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MWAR-45) add config prop to specify webapp classes
should be zipped and placed into WEB-INF/lib/xxx.jar instead of placed in
WEB-INF/classes/
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-45?page=all ]
Jason van Zyl closed MWAR-45:
-----------------------------
Resolution: Fixed
Patch applied and snapshot deploy, so grab the snapshot and make sure it works correctly for you. I tried it quickly with a webapp I'm working on and it seems to work.
There is now a boolean option to archive the classes and the JAR produced follows standard Maven naming conventions.
> add config prop to specify webapp classes should be zipped and placed into WEB-INF/lib/xxx.jar instead of placed in WEB-INF/classes/
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MWAR-45
> URL: http://jira.codehaus.org/browse/MWAR-45
> Project: Maven 2.x War Plugin
> Type: New Feature
> Versions: 2.0
> Reporter: Ian Springer
> Assignee: Jason van Zyl
> Attachments: mwar-45.patch
>
>
> I think this is a common enough practice that there should be an option provided for it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-45) add config prop to specify webapp
classes should be zipped and placed into WEB-INF/lib/xxx.jar instead of
placed in WEB-INF/classes/
Posted by "Torgeir Lorange ?stby (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-45?page=comments#action_67021 ]
Torgeir Lorange Østby commented on MWAR-45:
-------------------------------------------
Would it be better if classesArchiveName defaults to ${project.build.finalName} and then have an additional parameter/flag which triggers the feature? I guess
{code:xml}
<configuration>
<classesArchiveName>${project.build.finalName}</classesArchiveName>
</configuration>
{code}
would give the same result, but it is not that intuitive that this is what actually makes the plugin behave differently.
> add config prop to specify webapp classes should be zipped and placed into WEB-INF/lib/xxx.jar instead of placed in WEB-INF/classes/
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MWAR-45
> URL: http://jira.codehaus.org/browse/MWAR-45
> Project: Maven 2.x War Plugin
> Type: New Feature
> Versions: 2.0
> Reporter: Ian Springer
> Assignee: Jason van Zyl
> Attachments: mwar-45.patch
>
>
> I think this is a common enough practice that there should be an option provided for it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-45) add config prop to specify webapp
classes should be zipped and placed into WEB-INF/lib/xxx.jar instead of
placed in WEB-INF/classes/
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-45?page=comments#action_67130 ]
Jason van Zyl commented on MWAR-45:
-----------------------------------
I agree that there should be a boolean parameter and the JAR name should come out with the standard Maven naming conventions.
> add config prop to specify webapp classes should be zipped and placed into WEB-INF/lib/xxx.jar instead of placed in WEB-INF/classes/
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MWAR-45
> URL: http://jira.codehaus.org/browse/MWAR-45
> Project: Maven 2.x War Plugin
> Type: New Feature
> Versions: 2.0
> Reporter: Ian Springer
> Assignee: Jason van Zyl
> Attachments: mwar-45.patch
>
>
> I think this is a common enough practice that there should be an option provided for it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-45) add config prop to specify webapp
classes should be zipped and placed into WEB-INF/lib/xxx.jar instead of
placed in WEB-INF/classes/
Posted by "Torgeir Lorange ?stby (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-45?page=comments#action_66923 ]
Torgeir Lorange Østby commented on MWAR-45:
-------------------------------------------
This feature makes it easier to overlay war files if you have files with the same name and path in the war projects you want to merge (e.g. in src/main/resources). With this, these files will end up in their respective jars instead of replacing each other during the overlay process (take the application context descriptor as an example).
> add config prop to specify webapp classes should be zipped and placed into WEB-INF/lib/xxx.jar instead of placed in WEB-INF/classes/
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MWAR-45
> URL: http://jira.codehaus.org/browse/MWAR-45
> Project: Maven 2.x War Plugin
> Type: New Feature
> Versions: 2.0
> Reporter: Ian Springer
> Attachments: mwar-45.patch
>
>
> I think this is a common enough practice that there should be an option provided for it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-45) add config prop to specify webapp
classes should be zipped and placed into WEB-INF/lib/xxx.jar instead of
placed in WEB-INF/classes/
Posted by "David Jencks (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-45?page=comments#action_66816 ]
David Jencks commented on MWAR-45:
----------------------------------
I think adding this capability is a very good idea. IIUC the only argument against it is that it is possible to get the same effect by putting the classes into a separate project. I think this ignores the different effects and affect of having 2 projects:
1. Having 2 projects forces you to maintain what you are likely to be thinking of as one project in two places: e.g. even without jsps, the web.xml is going to be far away in the file system and IDE from the classes it is the descriptor for. I think breaking the way people think about their project in this way is inadvisable.
2. If you have jsps, you cannot precompile them and include them in the project classes jar without moving them into the classes project. What should be a packaging option requires major svn changes to your project.
3. With 2 projects you are forced to publish the classes jar. You may not want to pollute your repo with this artifact that you may regard as unnecessary. Also, you are apt to want to name both projects with the same name.
4. If you want 2 profiles, one to pack classes into a jar and the other to leave them in WEB-INF/classes, you are forced to unpack the jar if the jar is from a separate project. This is going to be a bit slower than not creating the jar in the first place.
I'm sure there are more, this is just what came to mind during a moments consideration. war files are a pretty strange and perhaps inadvisable construction, but I think it is better for maven to try to adapt to what they are and how they are used rather than trying to force everyone to essentially use something else.
> add config prop to specify webapp classes should be zipped and placed into WEB-INF/lib/xxx.jar instead of placed in WEB-INF/classes/
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MWAR-45
> URL: http://jira.codehaus.org/browse/MWAR-45
> Project: Maven 2.x War Plugin
> Type: New Feature
> Versions: 2.0
> Reporter: Ian Springer
> Attachments: mwar-45.patch
>
>
> I think this is a common enough practice that there should be an option provided for it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-45) add config prop to specify webapp classes
should be zipped and placed into WEB-INF/lib/xxx.jar instead of placed in
WEB-INF/classes/
Posted by "Prasad Kashyap (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-45?page=all ]
Prasad Kashyap updated MWAR-45:
-------------------------------
Attachment: mwar-45.patch
> add config prop to specify webapp classes should be zipped and placed into WEB-INF/lib/xxx.jar instead of placed in WEB-INF/classes/
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MWAR-45
> URL: http://jira.codehaus.org/browse/MWAR-45
> Project: Maven 2.x War Plugin
> Type: New Feature
> Versions: 2.0
> Reporter: Ian Springer
> Attachments: mwar-45.patch
>
>
> I think this is a common enough practice that there should be an option provided for it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-45) add config prop to specify webapp
classes should be zipped and placed into WEB-INF/lib/xxx.jar instead of
placed in WEB-INF/classes/
Posted by "Ian Springer (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-45?page=comments#action_67041 ]
Ian Springer commented on MWAR-45:
----------------------------------
+1 to Torgeir's suggestion. I think having a boolean parameter for enabling the option is more intuitive.
> add config prop to specify webapp classes should be zipped and placed into WEB-INF/lib/xxx.jar instead of placed in WEB-INF/classes/
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MWAR-45
> URL: http://jira.codehaus.org/browse/MWAR-45
> Project: Maven 2.x War Plugin
> Type: New Feature
> Versions: 2.0
> Reporter: Ian Springer
> Assignee: Jason van Zyl
> Attachments: mwar-45.patch
>
>
> I think this is a common enough practice that there should be an option provided for it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira