You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/09/08 23:39:43 UTC

[GitHub] [kafka] hachikuji commented on a change in pull request #11313: MINOR: GroupMetadataManager#shutdown should remove metrics

hachikuji commented on a change in pull request #11313:
URL: https://github.com/apache/kafka/pull/11313#discussion_r704847225



##########
File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##########
@@ -977,6 +977,9 @@ class GroupMetadataManager(brokerId: Int,
     shuttingDown.set(true)
     if (scheduler.isStarted)
       scheduler.shutdown()
+    metrics.removeSensor(GroupMetadataManager.LoadTimeSensor)
+    metrics.removeSensor("OffsetCommits")

Review comment:
       nit: maybe we could add a constant for these two similar to `GroupMetadataManager.LoadTimeSensor`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org