You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2017/11/03 01:53:47 UTC
Review Request 63533: HIVE-17906 use kill query mechanics to kill
queries in WM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63533/
-----------------------------------------------------------
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 9c2b3ea15c
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 0dd1433a6c
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java b0c6d583f0
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 94f42ddae0
Diff: https://reviews.apache.org/r/63533/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill
queries in WM
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Nov. 9, 2017, 2:05 a.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
> > Lines 494 (patched)
> > <https://reviews.apache.org/r/63533/diff/3/?file=1885126#file1885126line506>
> >
> > why are we putting back if NOT_FOUND? should this be destroyed instead? this session will still be NOT_FOUND in next iteration of event processing right?
No, it closes the old session and opens a new one
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63533/#review190530
-----------------------------------------------------------
On Nov. 8, 2017, 9:12 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63533/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2017, 9:12 p.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java fa0eedb1e2
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 0dd1433a6c
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 169991c639
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 0347e914bc
>
>
> Diff: https://reviews.apache.org/r/63533/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill
queries in WM
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63533/#review190530
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java
Lines 194 (patched)
<https://reviews.apache.org/r/63533/#comment267982>
throw in that case? asserts are disabled by default
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Lines 117 (patched)
<https://reviews.apache.org/r/63533/#comment267983>
the are not init'ed in c'tor. so can't be made final.
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Lines 123 (patched)
<https://reviews.apache.org/r/63533/#comment267984>
nit: Map
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Lines 310 (patched)
<https://reviews.apache.org/r/63533/#comment267985>
nit: Map, List
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Lines 494 (patched)
<https://reviews.apache.org/r/63533/#comment267988>
why are we putting back if NOT_FOUND? should this be destroyed instead? this session will still be NOT_FOUND in next iteration of event processing right?
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Lines 1703 (patched)
<https://reviews.apache.org/r/63533/#comment267989>
nit: print queryId as well. or add queryId to WmTezSession toString()
- Prasanth_J
On Nov. 8, 2017, 9:12 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63533/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2017, 9:12 p.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java fa0eedb1e2
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 0dd1433a6c
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 169991c639
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 0347e914bc
>
>
> Diff: https://reviews.apache.org/r/63533/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill
queries in WM
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63533/
-----------------------------------------------------------
(Updated Nov. 14, 2017, 1 a.m.)
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 03a068257e
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 6cf2aad34d
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java bdbcce5666
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java a73a24aef3
Diff: https://reviews.apache.org/r/63533/diff/5/
Changes: https://reviews.apache.org/r/63533/diff/4-5/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill
queries in WM
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63533/#review190909
-----------------------------------------------------------
Ship it!
Ship It!
- Prasanth_J
On Nov. 9, 2017, 10:33 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63533/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2017, 10:33 p.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 03a068257e
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 0dd1433a6c
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 16f5dce10a
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 84a35cc78c
>
>
> Diff: https://reviews.apache.org/r/63533/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill
queries in WM
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63533/
-----------------------------------------------------------
(Updated Nov. 9, 2017, 10:33 p.m.)
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 03a068257e
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 0dd1433a6c
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 16f5dce10a
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 84a35cc78c
Diff: https://reviews.apache.org/r/63533/diff/4/
Changes: https://reviews.apache.org/r/63533/diff/3-4/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill
queries in WM
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63533/
-----------------------------------------------------------
(Updated Nov. 8, 2017, 9:12 p.m.)
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java fa0eedb1e2
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 0dd1433a6c
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 169991c639
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 0347e914bc
Diff: https://reviews.apache.org/r/63533/diff/3/
Changes: https://reviews.apache.org/r/63533/diff/2-3/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill
queries in WM
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63533/#review190417
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Lines 459 (patched)
<https://reviews.apache.org/r/63533/#comment267744>
needs to continue
- Sergey Shelukhin
On Nov. 8, 2017, 2:29 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63533/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2017, 2:29 a.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java fa0eedb1e2
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 0dd1433a6c
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 169991c639
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 0347e914bc
>
>
> Diff: https://reviews.apache.org/r/63533/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill
queries in WM
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63533/
-----------------------------------------------------------
(Updated Nov. 8, 2017, 2:29 a.m.)
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java fa0eedb1e2
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 0dd1433a6c
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 169991c639
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 0347e914bc
Diff: https://reviews.apache.org/r/63533/diff/2/
Changes: https://reviews.apache.org/r/63533/diff/1-2/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill
queries in WM
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63533/#review190060
-----------------------------------------------------------
Ship it!
Ship It!
- Prasanth_J
On Nov. 3, 2017, 1:53 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63533/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2017, 1:53 a.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 9c2b3ea15c
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 0dd1433a6c
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java b0c6d583f0
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 94f42ddae0
>
>
> Diff: https://reviews.apache.org/r/63533/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>