You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2014/07/01 14:34:22 UTC
[GitHub] couchdb pull request: Fauxton View improvements
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb/pull/254
Fauxton View improvements
This fixes the bug with stale query option. As well as adding an extension to filter out what views
should be displayed in the side bar. An example of usage is to only display views that have
"language:javascript".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb view-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/254.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #254
----
commit dc1b1484918205570db34349c5875f7e050d31f9
Author: Garren Smith <ga...@gmail.com>
Date: 2014-06-30T10:27:18Z
Fix missing stale query option
commit defe78d3cbee95e8240cb670e18dd3fdaeb059fb
Author: Garren Smith <ga...@gmail.com>
Date: 2014-07-01T12:31:12Z
Fauxton: Add view filter
This allows a module to register an extension to filter out what views
should be displayed in the side bar.
An example of usage is to only display views that have
"language:javascript"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fauxton View improvements
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/254#issuecomment-47747791
Thanks merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fauxton View improvements
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb/pull/254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fauxton View improvements
Posted by drsm79 <gi...@git.apache.org>.
Github user drsm79 commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/254#discussion_r14405549
--- Diff: src/fauxton/app/addons/documents/resources.js ---
@@ -482,6 +482,14 @@ function(app, FauxtonAPI, PagingCollection) {
});
return PagingCollection.prototype.parse.call(this, resp);
+ },
+
+ clone: function () {
--- End diff --
Would using http://backbonejs.org/#Collection-clone be better/possible here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fauxton View improvements
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/254#discussion_r14406555
--- Diff: src/fauxton/app/addons/documents/resources.js ---
@@ -482,6 +482,14 @@ function(app, FauxtonAPI, PagingCollection) {
});
return PagingCollection.prototype.parse.call(this, resp);
+ },
+
+ clone: function () {
--- End diff --
Backbone.clone does copy across attributes so we cannot use it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fauxton View improvements
Posted by drsm79 <gi...@git.apache.org>.
Github user drsm79 commented on the pull request:
https://github.com/apache/couchdb/pull/254#issuecomment-47659961
LGTM - maybe worth squashing the first two commits and doing the stale fix in another PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---