You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/10/20 16:50:43 UTC
Review Request 26934: Ambari should support for Pig-on-Tez
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26934/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen and Vitalyi Brodetskyi.
Bugs: AMBARI-7863
https://issues.apache.org/jira/browse/AMBARI-7863
Repository: ambari
Description
-------
Pig on Tez will be in Champlain and we need Ambari support it
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 785b89d
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 7619bd6
ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml bd0b5ce
Diff: https://reviews.apache.org/r/26934/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [2.398s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.173s]
[INFO] Ambari Web ........................................ SUCCESS [44.231s]
[INFO] Ambari Views ...................................... SUCCESS [2.718s]
[INFO] Ambari Admin View ................................. SUCCESS [59.651s]
[INFO] Ambari Server ..................................... SUCCESS [43.740s]
[INFO] Ambari Agent ...................................... SUCCESS [5.398s]
[INFO] Ambari Client ..................................... SUCCESS [0.002s]
[INFO] Ambari Python Client .............................. SUCCESS [1.114s]
[INFO] Ambari Groovy Client .............................. SUCCESS [3.191s]
[INFO] Ambari Shell ...................................... SUCCESS [0.003s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.003s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [3.005s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 26934: Ambari should support for Pig-on-Tez
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26934/#review57331
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Жов. 20, 2014, 2:50 після полудня, Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26934/
> -----------------------------------------------------------
>
> (Updated Жов. 20, 2014, 2:50 після полудня)
>
>
> Review request for Ambari, Dmytro Sen and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-7863
> https://issues.apache.org/jira/browse/AMBARI-7863
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Pig on Tez will be in Champlain and we need Ambari support it
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 785b89d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 7619bd6
> ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml bd0b5ce
>
> Diff: https://reviews.apache.org/r/26934/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.398s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.173s]
> [INFO] Ambari Web ........................................ SUCCESS [44.231s]
> [INFO] Ambari Views ...................................... SUCCESS [2.718s]
> [INFO] Ambari Admin View ................................. SUCCESS [59.651s]
> [INFO] Ambari Server ..................................... SUCCESS [43.740s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.398s]
> [INFO] Ambari Client ..................................... SUCCESS [0.002s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.114s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [3.191s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.003s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.003s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [3.005s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 26934: Ambari should support for Pig-on-Tez
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Oct. 21, 2014, 2:30 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py, line 68
> > <https://reviews.apache.org/r/26934/diff/3/?file=725995#file725995line68>
> >
> > This is not a big issue, but stylistically, we should follow the PEP 8 style guide so that params are indented right below the "(", and the "=" is directly after the parameter name.
I'm sorry, but I've missed this comment before commit. Will copy this comment to related jira (externalizing check to function)
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26934/#review57531
-----------------------------------------------------------
On Oct. 20, 2014, 6:37 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26934/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 6:37 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-7863
> https://issues.apache.org/jira/browse/AMBARI-7863
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Pig on Tez will be in Champlain and we need Ambari support it
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 1308aa2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 5e1221a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 785b89d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 7619bd6
> ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml bd0b5ce
> ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py 2874614
>
> Diff: https://reviews.apache.org/r/26934/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.398s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.173s]
> [INFO] Ambari Web ........................................ SUCCESS [44.231s]
> [INFO] Ambari Views ...................................... SUCCESS [2.718s]
> [INFO] Ambari Admin View ................................. SUCCESS [59.651s]
> [INFO] Ambari Server ..................................... SUCCESS [43.740s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.398s]
> [INFO] Ambari Client ..................................... SUCCESS [0.002s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.114s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [3.191s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.003s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.003s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [3.005s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 26934: Ambari should support for Pig-on-Tez
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26934/#review57531
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py
<https://reviews.apache.org/r/26934/#comment98264>
This is not a big issue, but stylistically, we should follow the PEP 8 style guide so that params are indented right below the "(", and the "=" is directly after the parameter name.
- Alejandro Fernandez
On Oct. 20, 2014, 6:37 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26934/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 6:37 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-7863
> https://issues.apache.org/jira/browse/AMBARI-7863
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Pig on Tez will be in Champlain and we need Ambari support it
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 1308aa2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 5e1221a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 785b89d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 7619bd6
> ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml bd0b5ce
> ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py 2874614
>
> Diff: https://reviews.apache.org/r/26934/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.398s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.173s]
> [INFO] Ambari Web ........................................ SUCCESS [44.231s]
> [INFO] Ambari Views ...................................... SUCCESS [2.718s]
> [INFO] Ambari Admin View ................................. SUCCESS [59.651s]
> [INFO] Ambari Server ..................................... SUCCESS [43.740s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.398s]
> [INFO] Ambari Client ..................................... SUCCESS [0.002s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.114s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [3.191s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.003s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.003s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [3.005s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 26934: Ambari should support for Pig-on-Tez
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26934/#review57393
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Жов. 20, 2014, 9:37 після полудня, Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26934/
> -----------------------------------------------------------
>
> (Updated Жов. 20, 2014, 9:37 після полудня)
>
>
> Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-7863
> https://issues.apache.org/jira/browse/AMBARI-7863
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Pig on Tez will be in Champlain and we need Ambari support it
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 1308aa2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 5e1221a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 785b89d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 7619bd6
> ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml bd0b5ce
> ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py 2874614
>
> Diff: https://reviews.apache.org/r/26934/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.398s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.173s]
> [INFO] Ambari Web ........................................ SUCCESS [44.231s]
> [INFO] Ambari Views ...................................... SUCCESS [2.718s]
> [INFO] Ambari Admin View ................................. SUCCESS [59.651s]
> [INFO] Ambari Server ..................................... SUCCESS [43.740s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.398s]
> [INFO] Ambari Client ..................................... SUCCESS [0.002s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.114s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [3.191s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.003s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.003s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [3.005s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 26934: Ambari should support for Pig-on-Tez
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26934/
-----------------------------------------------------------
(Updated Oct. 20, 2014, 6:37 p.m.)
Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Vitalyi Brodetskyi.
Bugs: AMBARI-7863
https://issues.apache.org/jira/browse/AMBARI-7863
Repository: ambari
Description
-------
Pig on Tez will be in Champlain and we need Ambari support it
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 1308aa2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 5e1221a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 785b89d
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 7619bd6
ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml bd0b5ce
ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py 2874614
Diff: https://reviews.apache.org/r/26934/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [2.398s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.173s]
[INFO] Ambari Web ........................................ SUCCESS [44.231s]
[INFO] Ambari Views ...................................... SUCCESS [2.718s]
[INFO] Ambari Admin View ................................. SUCCESS [59.651s]
[INFO] Ambari Server ..................................... SUCCESS [43.740s]
[INFO] Ambari Agent ...................................... SUCCESS [5.398s]
[INFO] Ambari Client ..................................... SUCCESS [0.002s]
[INFO] Ambari Python Client .............................. SUCCESS [1.114s]
[INFO] Ambari Groovy Client .............................. SUCCESS [3.191s]
[INFO] Ambari Shell ...................................... SUCCESS [0.003s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.003s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [3.005s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 26934: Ambari should support for Pig-on-Tez
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26934/
-----------------------------------------------------------
(Updated Oct. 20, 2014, 6:36 p.m.)
Review request for Ambari, Dmytro Sen and Vitalyi Brodetskyi.
Changes
-------
Added tests
Bugs: AMBARI-7863
https://issues.apache.org/jira/browse/AMBARI-7863
Repository: ambari
Description
-------
Pig on Tez will be in Champlain and we need Ambari support it
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 1308aa2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 5e1221a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 785b89d
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 7619bd6
ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml bd0b5ce
ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py 2874614
Diff: https://reviews.apache.org/r/26934/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [2.398s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.173s]
[INFO] Ambari Web ........................................ SUCCESS [44.231s]
[INFO] Ambari Views ...................................... SUCCESS [2.718s]
[INFO] Ambari Admin View ................................. SUCCESS [59.651s]
[INFO] Ambari Server ..................................... SUCCESS [43.740s]
[INFO] Ambari Agent ...................................... SUCCESS [5.398s]
[INFO] Ambari Client ..................................... SUCCESS [0.002s]
[INFO] Ambari Python Client .............................. SUCCESS [1.114s]
[INFO] Ambari Groovy Client .............................. SUCCESS [3.191s]
[INFO] Ambari Shell ...................................... SUCCESS [0.003s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.003s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [3.005s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 26934: Ambari should support for Pig-on-Tez
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26934/#review57340
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Окт. 20, 2014, 3:32 п.п., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26934/
> -----------------------------------------------------------
>
> (Updated Окт. 20, 2014, 3:32 п.п.)
>
>
> Review request for Ambari, Dmytro Sen and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-7863
> https://issues.apache.org/jira/browse/AMBARI-7863
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Pig on Tez will be in Champlain and we need Ambari support it
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 1308aa2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 5e1221a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 785b89d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 7619bd6
> ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml bd0b5ce
>
> Diff: https://reviews.apache.org/r/26934/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.398s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.173s]
> [INFO] Ambari Web ........................................ SUCCESS [44.231s]
> [INFO] Ambari Views ...................................... SUCCESS [2.718s]
> [INFO] Ambari Admin View ................................. SUCCESS [59.651s]
> [INFO] Ambari Server ..................................... SUCCESS [43.740s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.398s]
> [INFO] Ambari Client ..................................... SUCCESS [0.002s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.114s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [3.191s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.003s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.003s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [3.005s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 26934: Ambari should support for Pig-on-Tez
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Oct. 20, 2014, 5:25 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py, line 215
> > <https://reviews.apache.org/r/26934/diff/2/?file=725768#file725768line215>
> >
> > This will not work in future stacks. Why not do int("".join(stack_version.split(".")[:2])) >= 22
> >
> > Or actually write a function to do this.
> > I believe we already have a function to compare Ambari versions, so we can use the similar logic for HDP.
Conversion to int might not work in some cases
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26934/#review57366
-----------------------------------------------------------
On Oct. 20, 2014, 3:32 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26934/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 3:32 p.m.)
>
>
> Review request for Ambari, Dmytro Sen and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-7863
> https://issues.apache.org/jira/browse/AMBARI-7863
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Pig on Tez will be in Champlain and we need Ambari support it
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 1308aa2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 5e1221a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 785b89d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 7619bd6
> ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml bd0b5ce
>
> Diff: https://reviews.apache.org/r/26934/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.398s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.173s]
> [INFO] Ambari Web ........................................ SUCCESS [44.231s]
> [INFO] Ambari Views ...................................... SUCCESS [2.718s]
> [INFO] Ambari Admin View ................................. SUCCESS [59.651s]
> [INFO] Ambari Server ..................................... SUCCESS [43.740s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.398s]
> [INFO] Ambari Client ..................................... SUCCESS [0.002s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.114s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [3.191s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.003s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.003s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [3.005s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 26934: Ambari should support for Pig-on-Tez
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26934/#review57366
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py
<https://reviews.apache.org/r/26934/#comment98022>
This will not work in future stacks. Why not do int("".join(stack_version.split(".")[:2])) >= 22
Or actually write a function to do this.
I believe we already have a function to compare Ambari versions, so we can use the similar logic for HDP.
- Alejandro Fernandez
On Oct. 20, 2014, 3:32 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26934/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 3:32 p.m.)
>
>
> Review request for Ambari, Dmytro Sen and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-7863
> https://issues.apache.org/jira/browse/AMBARI-7863
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Pig on Tez will be in Champlain and we need Ambari support it
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 1308aa2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 5e1221a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 785b89d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 7619bd6
> ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml bd0b5ce
>
> Diff: https://reviews.apache.org/r/26934/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.398s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.173s]
> [INFO] Ambari Web ........................................ SUCCESS [44.231s]
> [INFO] Ambari Views ...................................... SUCCESS [2.718s]
> [INFO] Ambari Admin View ................................. SUCCESS [59.651s]
> [INFO] Ambari Server ..................................... SUCCESS [43.740s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.398s]
> [INFO] Ambari Client ..................................... SUCCESS [0.002s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.114s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [3.191s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.003s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.003s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [3.005s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 26934: Ambari should support for Pig-on-Tez
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26934/
-----------------------------------------------------------
(Updated Oct. 20, 2014, 3:32 p.m.)
Review request for Ambari, Dmytro Sen and Vitalyi Brodetskyi.
Bugs: AMBARI-7863
https://issues.apache.org/jira/browse/AMBARI-7863
Repository: ambari
Description
-------
Pig on Tez will be in Champlain and we need Ambari support it
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 1308aa2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 5e1221a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 785b89d
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 7619bd6
ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml bd0b5ce
Diff: https://reviews.apache.org/r/26934/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [2.398s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.173s]
[INFO] Ambari Web ........................................ SUCCESS [44.231s]
[INFO] Ambari Views ...................................... SUCCESS [2.718s]
[INFO] Ambari Admin View ................................. SUCCESS [59.651s]
[INFO] Ambari Server ..................................... SUCCESS [43.740s]
[INFO] Ambari Agent ...................................... SUCCESS [5.398s]
[INFO] Ambari Client ..................................... SUCCESS [0.002s]
[INFO] Ambari Python Client .............................. SUCCESS [1.114s]
[INFO] Ambari Groovy Client .............................. SUCCESS [3.191s]
[INFO] Ambari Shell ...................................... SUCCESS [0.003s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.003s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [3.005s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko