You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Sam Pullara (JIRA)" <ji...@apache.org> on 2008/01/11 20:48:34 UTC
[jira] Created: (PIG-60) User-defined comparison operators don't
work in locally executing PIG
User-defined comparison operators don't work in locally executing PIG
----------------------------------------------------------------------
Key: PIG-60
URL: https://issues.apache.org/jira/browse/PIG-60
Project: Pig
Issue Type: Bug
Environment: java 5, mac
Reporter: Sam Pullara
I will attach a patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIG-60) User-defined comparison operators don't
work in locally executing PIG
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich resolved PIG-60.
-------------------------------
Resolution: Duplicate
This is duplicate of PIG-202
> User-defined comparison operators don't work in locally executing PIG
> ----------------------------------------------------------------------
>
> Key: PIG-60
> URL: https://issues.apache.org/jira/browse/PIG-60
> Project: Pig
> Issue Type: Bug
> Environment: java 5, mac
> Reporter: Sam Pullara
> Attachments: fixlocalcomparison.patch
>
>
> I will attach a patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-60) User-defined comparison operators don't
work in locally executing PIG
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558888#action_12558888 ]
Alan Gates commented on PIG-60:
-------------------------------
In this patch I noticed you use Class.forName to find the comparator. Does this need to be changed to PigContext.resolveClassName() (as in MapreducePlanCompiler) or will Class.forName do what you want here?
> User-defined comparison operators don't work in locally executing PIG
> ----------------------------------------------------------------------
>
> Key: PIG-60
> URL: https://issues.apache.org/jira/browse/PIG-60
> Project: Pig
> Issue Type: Bug
> Environment: java 5, mac
> Reporter: Sam Pullara
> Attachments: fixlocalcomparison.patch
>
>
> I will attach a patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-60) User-defined comparison operators don't
work in locally executing PIG
Posted by "Sam Pullara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558891#action_12558891 ]
Sam Pullara commented on PIG-60:
--------------------------------
I changed it to PigContext. instantiateFuncFromSpec and that worked well.
> User-defined comparison operators don't work in locally executing PIG
> ----------------------------------------------------------------------
>
> Key: PIG-60
> URL: https://issues.apache.org/jira/browse/PIG-60
> Project: Pig
> Issue Type: Bug
> Environment: java 5, mac
> Reporter: Sam Pullara
> Attachments: fixlocalcomparison.patch
>
>
> I will attach a patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-60) User-defined comparison operators don't
work in locally executing PIG
Posted by "Sam Pullara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sam Pullara updated PIG-60:
---------------------------
Attachment: fixlocalcomparison.patch
> User-defined comparison operators don't work in locally executing PIG
> ----------------------------------------------------------------------
>
> Key: PIG-60
> URL: https://issues.apache.org/jira/browse/PIG-60
> Project: Pig
> Issue Type: Bug
> Environment: java 5, mac
> Reporter: Sam Pullara
> Attachments: fixlocalcomparison.patch
>
>
> I will attach a patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-60) User-defined comparison operators don't
work in locally executing PIG
Posted by "Benjamin Francisoud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573841#action_12573841 ]
Benjamin Francisoud commented on PIG-60:
----------------------------------------
I think [Alan comment|https://issues.apache.org/jira/browse/PIG-60?focusedCommentId=12559152#action_12559152] doesn't apply anymore.
You don't need a cluster since unit tests should use MiniCluster now to avoid such problem.
my 2 cents
> User-defined comparison operators don't work in locally executing PIG
> ----------------------------------------------------------------------
>
> Key: PIG-60
> URL: https://issues.apache.org/jira/browse/PIG-60
> Project: Pig
> Issue Type: Bug
> Environment: java 5, mac
> Reporter: Sam Pullara
> Attachments: fixlocalcomparison.patch
>
>
> I will attach a patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-60) User-defined comparison operators don't
work in locally executing PIG
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558095#action_12558095 ]
Olga Natkovich commented on PIG-60:
-----------------------------------
Alan, could you review the proposed change. Also, could you run the unit tests as Sam was unable to get them going, thanks.
> User-defined comparison operators don't work in locally executing PIG
> ----------------------------------------------------------------------
>
> Key: PIG-60
> URL: https://issues.apache.org/jira/browse/PIG-60
> Project: Pig
> Issue Type: Bug
> Environment: java 5, mac
> Reporter: Sam Pullara
> Attachments: fixlocalcomparison.patch
>
>
> I will attach a patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-60) User-defined comparison operators don't
work in locally executing PIG
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559152#action_12559152 ]
Alan Gates commented on PIG-60:
-------------------------------
Two of the junit tests failed with this change, TestOrderBy.testNestedOrderBy_Col2_Using and TestOrderBy.testNestedOrderBy_Col21_Using
Sam, you'll need to have a small hadoop cluster to run against, and then the command:
ant -Djunit.hadoop.conf=<configdir> -Dhod.server= test
(where <configdir> is the directory that holds the hadoop-site.xml file for your cluster resides)
should run the unit tests for you.
> User-defined comparison operators don't work in locally executing PIG
> ----------------------------------------------------------------------
>
> Key: PIG-60
> URL: https://issues.apache.org/jira/browse/PIG-60
> Project: Pig
> Issue Type: Bug
> Environment: java 5, mac
> Reporter: Sam Pullara
> Attachments: fixlocalcomparison.patch
>
>
> I will attach a patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-60) User-defined comparison operators don't
work in locally executing PIG
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-60:
------------------------------
Patch Info: (was: [Patch Available])
cleared "patch available" flag since this patch needs to be updated
> User-defined comparison operators don't work in locally executing PIG
> ----------------------------------------------------------------------
>
> Key: PIG-60
> URL: https://issues.apache.org/jira/browse/PIG-60
> Project: Pig
> Issue Type: Bug
> Environment: java 5, mac
> Reporter: Sam Pullara
> Attachments: fixlocalcomparison.patch
>
>
> I will attach a patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (PIG-60) User-defined comparison
operators don't work in locally executing PIG
Posted by "Benjamin Francisoud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573841#action_12573841 ]
francisoud edited comment on PIG-60 at 2/29/08 9:33 AM:
-----------------------------------------------------------------
I think [Alan comment|https://issues.apache.org/jira/browse/PIG-60?focusedCommentId=12559152#action_12559152] about having a cluster to run tests; doesn't apply anymore.
You don't need a cluster since unit tests should use MiniCluster now to avoid such problem. (PIG-72)
my 2 cents
was (Author: francisoud):
I think [Alan comment|https://issues.apache.org/jira/browse/PIG-60?focusedCommentId=12559152#action_12559152] doesn't apply anymore.
You don't need a cluster since unit tests should use MiniCluster now to avoid such problem.
my 2 cents
> User-defined comparison operators don't work in locally executing PIG
> ----------------------------------------------------------------------
>
> Key: PIG-60
> URL: https://issues.apache.org/jira/browse/PIG-60
> Project: Pig
> Issue Type: Bug
> Environment: java 5, mac
> Reporter: Sam Pullara
> Attachments: fixlocalcomparison.patch
>
>
> I will attach a patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.