You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/16 22:16:47 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4249: Minor: remove unecessary clone() in planner
alamb opened a new pull request, #4249:
URL: https://github.com/apache/arrow-datafusion/pull/4249
# Which issue does this PR close?
N/A
# Rationale for this change
I noticed this while working on https://github.com/apache/arrow-datafusion/pull/4226
# What changes are included in this PR?
remove some unecessary clone()
# Are these changes tested?
yes by existing tests
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4249: Minor: remove unecessary clone() in planner
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4249:
URL: https://github.com/apache/arrow-datafusion/pull/4249#issuecomment-1318794645
Benchmark runs are scheduled for baseline = e18f7bac209987dcc95c1bfa01de9c13ef75efe4 and contender = 6f62870e6e640c4a3f486fbe9bdf49b30c0b5c34. 6f62870e6e640c4a3f486fbe9bdf49b30c0b5c34 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e97c339fa42a4574927cf7f12cfe4a96...aef3e3bcad704d4491dcb0502f76bb73/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/0de3ce9e835e447b9dfca7d37362b022...b2fb7a2ed0e9441f81d7e8b64fafd2f6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bc8b0799c80d482eb011e724e245f48d...09472988a655489dbdde73359e1d56b6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6fbda19f36ca437e828a7cbaccbe367e...61f2ade791f947ee921f47da7435ee1a/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4249: Minor: remove unecessary clone() in planner
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4249:
URL: https://github.com/apache/arrow-datafusion/pull/4249#issuecomment-1317935389
Failing due to https://github.com/apache/arrow-datafusion/pull/4252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4249: Minor: remove unecessary clone() in planner
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #4249:
URL: https://github.com/apache/arrow-datafusion/pull/4249#discussion_r1025069978
##########
datafusion/sql/src/planner.rs:
##########
@@ -2314,11 +2314,11 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
SQLExpr::Nested(e) => self.sql_expr_to_logical_expr(*e, schema, ctes),
- SQLExpr::Exists { subquery, negated } => self.parse_exists_subquery(&subquery, negated, schema, ctes),
+ SQLExpr::Exists { subquery, negated } => self.parse_exists_subquery(*subquery, negated, schema, ctes),
Review Comment:
it already has an owned copy -- there is no reason to pass in a reference to just clone it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #4249: Minor: remove unecessary clone() in planner
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #4249:
URL: https://github.com/apache/arrow-datafusion/pull/4249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org