You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/12/09 22:26:32 UTC

[commons-vfs] branch master updated: JApiCmp: Allow source changes on throws declarations. Binary breaks still break the build. Fix JapiCmp reported error but it feels like a false positive.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git


The following commit(s) were added to refs/heads/master by this push:
     new 77e7127  JApiCmp: Allow source changes on throws declarations. Binary breaks still break the build. Fix JapiCmp reported error but it feels like a false positive.
77e7127 is described below

commit 77e71279d4438f749f5e3b1214c9301e42a9bb42
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Dec 9 17:26:26 2021 -0500

    JApiCmp: Allow source changes on throws declarations. Binary breaks
    still break the build. Fix JapiCmp reported error but it feels like a
    false positive.
---
 .../main/java/org/apache/commons/vfs2/util/RandomAccessMode.java   | 6 +++++-
 pom.xml                                                            | 7 +++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/RandomAccessMode.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/RandomAccessMode.java
index 41b1b68..0e4cf0e 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/RandomAccessMode.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/RandomAccessMode.java
@@ -136,6 +136,10 @@ public enum RandomAccessMode {
      * @return an array of {@link AccessMode}.
      * @since 2.10.0
      */
-    public abstract AccessMode[] toAccessModes();
+    public AccessMode[] toAccessModes() {
+        // TODO If this method is abstract, JApiCmp reports:
+        // org.apache.commons.vfs2.util.RandomAccessMode.toAccessModes():METHOD_ABSTRACT_ADDED_TO_CLASS,org.apache.commons.vfs2.util.RandomAccessMode:CLASS_NOW_ABSTRACT
+        return null;
+    }
 
 }
diff --git a/pom.xml b/pom.xml
index 0117626..1920ef0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -389,6 +389,13 @@
                 <sourceCompatible>true</sourceCompatible>
                 <semanticVersionLevel>PATCH</semanticVersionLevel>
               </overrideCompatibilityChangeParameter>
+              <overrideCompatibilityChangeParameter>
+                <!-- BC is maintained, but no SC. -->
+                <compatibilityChange>METHOD_NO_LONGER_THROWS_CHECKED_EXCEPTION</compatibilityChange>
+                <binaryCompatible>true</binaryCompatible>
+                <sourceCompatible>true</sourceCompatible>
+                <semanticVersionLevel>PATCH</semanticVersionLevel>
+              </overrideCompatibilityChangeParameter>
             </overrideCompatibilityChangeParameters>
             <excludes>
               <!--  Package moved to new module -->