You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/12/03 20:13:03 UTC
[GitHub] ccollins476ad commented on a change in pull request #1545: adding
battery polling rate 0 to stop polling
ccollins476ad commented on a change in pull request #1545: adding battery polling rate 0 to stop polling
URL: https://github.com/apache/mynewt-core/pull/1545#discussion_r238420276
##########
File path: hw/battery/src/battery.c
##########
@@ -487,10 +487,15 @@ battery_set_poll_rate_ms(struct os_dev *battery, uint32_t poll_rate)
{
struct battery *bat = (struct battery *)battery;
- if ((poll_rate == 0) || (bat == NULL)) {
+ if ((bat == NULL)) {
Review comment:
Just a nitpick, but you could remove the extra set of parentheses here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services