You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by "Philip Harvey (JIRA)" <ji...@apache.org> on 2012/11/29 10:26:58 UTC

[jira] [Created] (PROTON-172) Implement SSL within proton-j

Philip Harvey created PROTON-172:
------------------------------------

             Summary: Implement SSL within proton-j
                 Key: PROTON-172
                 URL: https://issues.apache.org/jira/browse/PROTON-172
             Project: Qpid Proton
          Issue Type: New Feature
          Components: proton-j
            Reporter: Philip Harvey
            Assignee: Philip Harvey


Implement SSL within proton-j

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PROTON-172) Implement SSL within proton-j

Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philip Harvey updated PROTON-172:
---------------------------------

    Attachment: 0001-PROTON-172-refactored-Java-SSL-implementation-to-mak.patch

refactored Java SSL implementation to make it more readable
                
> Implement SSL within proton-j
> -----------------------------
>
>                 Key: PROTON-172
>                 URL: https://issues.apache.org/jira/browse/PROTON-172
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Philip Harvey
>            Assignee: Keith Wall
>         Attachments: 0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch, 0001-PROTON-172-refactored-Java-SSL-implementation-to-mak.patch, 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch
>
>
> Implement SSL within proton-j

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (PROTON-172) Implement SSL within proton-j

Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philip Harvey reassigned PROTON-172:
------------------------------------

    Assignee: Rob Godfrey  (was: Keith Wall)

hi Rob, pls could you review the updated patches and commit if you're happy
                
> Implement SSL within proton-j
> -----------------------------
>
>                 Key: PROTON-172
>                 URL: https://issues.apache.org/jira/browse/PROTON-172
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Philip Harvey
>            Assignee: Rob Godfrey
>         Attachments: 0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch, 0001-PROTON-172-refactored-Java-SSL-implementation-to-mak.patch, 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch, 0002-PROTON-172-Moved-SSL-classes-into-package-org.engine.patch
>
>
> Implement SSL within proton-j

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PROTON-172) Implement SSL within proton-j

Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philip Harvey updated PROTON-172:
---------------------------------

    Attachment: 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch
                0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch

The first patch adds SSL support to proton-j and is ready to be committed now.The second contains a extra test and enhanced pump method - this can't be commit until the PROTON-171 it resolved
                
> Implement SSL within proton-j
> -----------------------------
>
>                 Key: PROTON-172
>                 URL: https://issues.apache.org/jira/browse/PROTON-172
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Philip Harvey
>            Assignee: Philip Harvey
>         Attachments: 0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch, 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch
>
>
> Implement SSL within proton-j

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PROTON-172) Implement SSL within proton-j

Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philip Harvey updated PROTON-172:
---------------------------------

    Attachment: 0002-PROTON-172-Moved-SSL-classes-into-package-org.engine.patch
                0001-PROTON-172-refactored-Java-SSL-implementation-to-mak.patch

refactored SSL implementation - extracted most byte buffer manipulation to improve readability. 

The second patch is only a package-move of the SSL classes into their own package, and a couple of visibility changes to PlainTransportWrapper and SslImpl.wrap to allow this.
                
> Implement SSL within proton-j
> -----------------------------
>
>                 Key: PROTON-172
>                 URL: https://issues.apache.org/jira/browse/PROTON-172
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Philip Harvey
>            Assignee: Keith Wall
>         Attachments: 0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch, 0001-PROTON-172-refactored-Java-SSL-implementation-to-mak.patch, 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch, 0002-PROTON-172-Moved-SSL-classes-into-package-org.engine.patch
>
>
> Implement SSL within proton-j

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (PROTON-172) Implement SSL within proton-j

Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall reassigned PROTON-172:
---------------------------------

    Assignee: Keith Wall  (was: Philip Harvey)
    
> Implement SSL within proton-j
> -----------------------------
>
>                 Key: PROTON-172
>                 URL: https://issues.apache.org/jira/browse/PROTON-172
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Philip Harvey
>            Assignee: Keith Wall
>         Attachments: 0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch, 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch
>
>
> Implement SSL within proton-j

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PROTON-172) Implement SSL within proton-j

Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philip Harvey updated PROTON-172:
---------------------------------

    Attachment:     (was: 0001-PROTON-172-refactored-Java-SSL-implementation-to-mak.patch)
    
> Implement SSL within proton-j
> -----------------------------
>
>                 Key: PROTON-172
>                 URL: https://issues.apache.org/jira/browse/PROTON-172
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Philip Harvey
>            Assignee: Keith Wall
>         Attachments: 0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch, 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch
>
>
> Implement SSL within proton-j

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PROTON-172) Implement SSL within proton-j

Posted by "Rob Godfrey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510711#comment-13510711 ] 

Rob Godfrey commented on PROTON-172:
------------------------------------

Reviewed and applied 0001-PROTON-172-refactored-Java-SSL-implementation-to-mak.patch and 0002-PROTON-172-Moved-SSL-classes-into-package-org.engine.patch
                
> Implement SSL within proton-j
> -----------------------------
>
>                 Key: PROTON-172
>                 URL: https://issues.apache.org/jira/browse/PROTON-172
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Philip Harvey
>            Assignee: Rob Godfrey
>         Attachments: 0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch, 0001-PROTON-172-refactored-Java-SSL-implementation-to-mak.patch, 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch, 0002-PROTON-172-Moved-SSL-classes-into-package-org.engine.patch
>
>
> Implement SSL within proton-j

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PROTON-172) Implement SSL within proton-j

Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506436#comment-13506436 ] 

Keith Wall commented on PROTON-172:
-----------------------------------

First patch applied (0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch)
                
> Implement SSL within proton-j
> -----------------------------
>
>                 Key: PROTON-172
>                 URL: https://issues.apache.org/jira/browse/PROTON-172
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>            Reporter: Philip Harvey
>            Assignee: Keith Wall
>         Attachments: 0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch, 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch
>
>
> Implement SSL within proton-j

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira