You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/06 20:06:24 UTC
[GitHub] [zookeeper] tamaashu opened a new pull request #1485: ZOOKEEPER-3958: Update dependency versions and eliminate java docs wa…
tamaashu opened a new pull request #1485:
URL: https://github.com/apache/zookeeper/pull/1485
…rnings
We have quite many outdated dependency which can be updated and also a few warnings during the build of JavaDocs.
Change-Id: I5c5ea0b566ced2d30dcf08bf76f6b3d87f700a4e
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tamaashu commented on pull request #1485: ZOOKEEPER-3958: Update dependency versions and eliminate java docs wa…
Posted by GitBox <gi...@apache.org>.
tamaashu commented on pull request #1485:
URL: https://github.com/apache/zookeeper/pull/1485#issuecomment-719037000
@eolivelli do you think this is ready to commit into the master branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tamaashu commented on pull request #1485: ZOOKEEPER-3958: Update dependency versions and eliminate java docs wa…
Posted by GitBox <gi...@apache.org>.
tamaashu commented on pull request #1485:
URL: https://github.com/apache/zookeeper/pull/1485#issuecomment-704965691
@eolivelli I have added a refreshment to dropwizard and prometheus too.
Metrics work for me properly, but since you have added prometheus it might worth to check deeper by you.
I've also updated the documentation as it didn't work for me on the written way with the newest prometheus (v2.21.0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tamaashu commented on a change in pull request #1485: ZOOKEEPER-3958: Update dependency versions and eliminate java docs wa…
Posted by GitBox <gi...@apache.org>.
tamaashu commented on a change in pull request #1485:
URL: https://github.com/apache/zookeeper/pull/1485#discussion_r500840774
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/CliCommand.java
##########
@@ -72,23 +72,23 @@ public void setZk(ZooKeeper zk) {
/**
* get the string used to call this command
- * @return
+ * @return cmdStr
Review comment:
Thanks, fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1485: ZOOKEEPER-3958: Update dependency versions and eliminate java docs wa…
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1485:
URL: https://github.com/apache/zookeeper/pull/1485#discussion_r500605596
##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/CliCommand.java
##########
@@ -72,23 +72,23 @@ public void setZk(ZooKeeper zk) {
/**
* get the string used to call this command
- * @return
+ * @return cmdStr
Review comment:
These don't really provide any value to the reader of the javadoc, as this variable is implementation details and are meaningless to the person reading the javadocs. These unneeded return tags should just be removed from the javadoc in these cases where there's no meaningful description in the return tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tamaashu edited a comment on pull request #1485: ZOOKEEPER-3958: Update dependency versions and eliminate java docs wa…
Posted by GitBox <gi...@apache.org>.
tamaashu edited a comment on pull request #1485:
URL: https://github.com/apache/zookeeper/pull/1485#issuecomment-704802501
> LGTM, thanks for the fixes / dependency upgrades.
> (it might worth to run a CVE check, although we only upgraded to newer versions, so I don't expect that we made things worse than they were)
@symat
I have updated these dependencies to their latest version, so if they contain any CVE then we have a problem...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tamaashu commented on pull request #1485: ZOOKEEPER-3958: Update dependency versions and eliminate java docs wa…
Posted by GitBox <gi...@apache.org>.
tamaashu commented on pull request #1485:
URL: https://github.com/apache/zookeeper/pull/1485#issuecomment-704802501
> LGTM, thanks for the fixes / dependency upgrades.
> (it might worth to run a CVE check, although we only upgraded to newer versions, so I don't expect that we made things worse than they were)
I have updated these dependencies to their latest version, so if they contain any CVE then we have a problem...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tamaashu commented on pull request #1485: ZOOKEEPER-3958: Update dependency versions and eliminate java docs wa…
Posted by GitBox <gi...@apache.org>.
tamaashu commented on pull request #1485:
URL: https://github.com/apache/zookeeper/pull/1485#issuecomment-705427169
I've just realized, I have to update some license files too. New commit needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tamaashu commented on pull request #1485: ZOOKEEPER-3958: Update dependency versions and eliminate java docs wa…
Posted by GitBox <gi...@apache.org>.
tamaashu commented on pull request #1485:
URL: https://github.com/apache/zookeeper/pull/1485#issuecomment-705427169
I've just realized, I have to update some license files too. New commit needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tamaashu edited a comment on pull request #1485: ZOOKEEPER-3958: Update dependency versions and eliminate java docs wa…
Posted by GitBox <gi...@apache.org>.
tamaashu edited a comment on pull request #1485:
URL: https://github.com/apache/zookeeper/pull/1485#issuecomment-705427169
I've just realized, I have to update some license files too. Done in a new commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tamaashu commented on pull request #1485: ZOOKEEPER-3958: Update dependency versions and eliminate java docs wa…
Posted by GitBox <gi...@apache.org>.
tamaashu commented on pull request #1485:
URL: https://github.com/apache/zookeeper/pull/1485#issuecomment-718228405
> @tamaashu The build warnings is an annoying and long-term coexistence issue. Thanks for this.
> By executing `mvn clean package -DskipTests`, I found other **61** building warnings(Look at this [file](https://issues.apache.org/jira/secure/attachment/13013603/build_warning.txt) I attached inot the JIRA). Am I missing something?
@maoling sorry, but after I ran the build with `mvn clean package -DskipTests`, I've only got one warning:
`[INFO] --- maven-jar-plugin:3.1.0:jar (default-jar) @ zookeeper-compatibility-tests-curator ---
[WARNING] JAR will be empty - no content was marked for inclusion!`
Is it possible that you have used an earlier version of this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tamaashu edited a comment on pull request #1485: ZOOKEEPER-3958: Update dependency versions and eliminate java docs wa…
Posted by GitBox <gi...@apache.org>.
tamaashu edited a comment on pull request #1485:
URL: https://github.com/apache/zookeeper/pull/1485#issuecomment-705427169
I've just realized, I have to update some license files too. Done in a new commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1485: ZOOKEEPER-3958: Update dependency versions and eliminate java docs wa…
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1485:
URL: https://github.com/apache/zookeeper/pull/1485#issuecomment-708857748
@tamaashu The build warnings is an annoying and long-term coexistence issue. Thanks for this.
By executing `mvn clean package -DskipTests`, I found other **61** building warnings(Look at this [file](https://issues.apache.org/jira/secure/attachment/13013603/build_warning.txt) I attached inot the JIRA). Am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org