You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/27 11:06:55 UTC
[GitHub] marcoabreu commented on a change in pull request #11036:
[MXNET-472] Add ccache support to CI
marcoabreu commented on a change in pull request #11036: [MXNET-472] Add ccache support to CI
URL: https://github.com/apache/incubator-mxnet/pull/11036#discussion_r191072956
##########
File path: make/config.mk
##########
@@ -37,8 +37,8 @@
# choice of compiler
#--------------------
-export CC = gcc
-export CXX = g++
+#export CC = gcc
Review comment:
What if someone does not set them explicitly? I agree with Anton that we should provide a default configuration instead of relying on the people having to set environment variables just to get compilation working
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services