[GitHub] [iceberg] pvary commented on a change in pull request #2785: Fix the problem that the metastore-client is not closed

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2785:
URL: https://github.com/apache/iceberg/pull/2785#discussion_r667895619



##########
File path: core/src/main/java/org/apache/iceberg/ClientPoolImpl.java
##########
@@ -140,4 +140,7 @@ private void release(C client) {
   public int poolSize() {
     return poolSize;
   }
+  public int getCurrentSize() {

Review comment:
       nit: newline

##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/CachedClientPool.java
##########
@@ -65,6 +68,16 @@ private synchronized void init() {
               .removalListener((key, value, cause) -> ((HiveClientPool) value).close())
               .build();
     }
+    Runtime.getRuntime().addShutdownHook(new Thread() {

Review comment:
       nit: newline




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org