You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/01/17 19:01:02 UTC

[GitHub] [sling-org-apache-sling-servlets-post] tomasalmeida opened a new pull request #10: SLING-10030 - Addin PostOperation ranking

tomasalmeida opened a new pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10


   - Migrating SlingPostServletTest to Junit4
   - Creating an auxiliary SortedByRankingList class which stores elements by a given ranking
   - Storing all bound PostOperations by ranking and using the one with higher ranking
      - if no ranking is provided, order follows the behavior already established behavior: last Operation bound is used as default one.
   
   Full proposal is described in https://issues.apache.org/jira/browse/SLING-10030


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] tomasalmeida commented on a change in pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
tomasalmeida commented on a change in pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r559230689



##########
File path: src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##########
@@ -0,0 +1,106 @@
+/*

Review comment:
       Hi Paul, great point, I kept the same insertion code used before just moving it to the new Class, so it could reused.
   
   I can reimplement it using a SortedMap as proposed. Although I am not sure we can guarantee if no ranking is provided, the last inserted element will be the chosen one.
   
   Let me know if I should provide the implementation using a SortedMap and I can provide it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] kwin commented on a change in pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r560063474



##########
File path: src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##########
@@ -0,0 +1,106 @@
+/*

Review comment:
       Please rather use DS field injection which orders automatically by ranking
   
   > For a reference with multiple cardinality, a field must be a collection of one of the following types:
   Collection
   List
   A subtype of Collection - This type can only be used for dynamic references using the update reference field option. The component instance must initialize the field to a collection object in its constructor.
   (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-field.injection)
   
   and
   > For a reference with multiple cardinality, the type of the field must be Collection or List. If the field has a different type, SCR must log an error message with the Log Service, if present, and the field must not be modified. Before the component instance is activated, SCR must set the field value with a new mutable collection that must contain the initial set of bound services sorted using the same ordering as ServiceReference.compareTo based upon service ranking and service id. The collection may be empty if the reference has optional cardinality and there are no bound services. If the reference is dynamic, when there is a change in the set of bound services or the service properties of a bound service are modified and the collection holds service properties, SCR must replace the field value with a new mutable collection that must contain the updated set of bound services sorted using the same ordering as ServiceReference.compareTo based upon service ranking and service id. 
 The new collection may be empty if the reference has optional cardinality and there are no bound services.
   
   (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#d0e37828




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-761862849


   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='74.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list) [74.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] tomasalmeida commented on a change in pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
tomasalmeida commented on a change in pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r559230689



##########
File path: src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##########
@@ -0,0 +1,106 @@
+/*

Review comment:
       Hi Paul, great point, I kept the same insertion code used before just moving it to the new Class, so it could reused.
   
   I can reimplement it using a SortedMap as proposed. Although I am not sure we can guarantee if no ranking is provided, the last inserted element will be the chosen one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] removed a comment on pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-761862849


   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='74.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list) [74.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] removed a comment on pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-761864165


   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='74.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list) [74.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] rombert commented on a change in pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
rombert commented on a change in pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r560869006



##########
File path: src/test/java/org/apache/sling/servlets/post/impl/SlingPostServletTest.java
##########
@@ -238,31 +355,31 @@ void setStatusParam(String statusParam) {
     }
 
     private static class SendErrorParamSlingHttpServletRequest extends
-	    MockSlingHttpServlet3Request {
-		
-		private String sendError;
-		
-		public SendErrorParamSlingHttpServletRequest() {
-		    // nothing to setup, we don't care
-		    super(null, null, null, null, null);
-		}
-		
-		@Override
-		public String getParameter(String name) {
-		    if (SlingPostConstants.RP_SEND_ERROR.equals(name)) {
-		        return sendError;
-		    }
-		
-		    return super.getParameter(name);
-		}
-		
-		void setSendError(String sendErrorParam) {
-		    this.sendError = sendErrorParam;
-		}
-		
-		public <AdapterType> AdapterType adaptTo(Class<AdapterType> type) {
-		    return null;
-		}
-	}
+            MockSlingHttpServlet3Request {

Review comment:
       Please avoid whitespace-only changes, or separate them to their own commits.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] tomasalmeida closed pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
tomasalmeida closed pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-761864165


   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='74.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list) [74.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-761870261


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='82.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list) [82.4% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] rombert commented on a change in pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
rombert commented on a change in pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r560024122



##########
File path: src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##########
@@ -0,0 +1,106 @@
+/*

Review comment:
       I would check what the OSGi core bundles do - I think that the 'sort by ranking' problem occurs there as well. @cziegeler / @karlpauls / @bosschaert  - any suggestions?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] removed a comment on pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-761870261


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='82.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list) [82.4% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] tomasalmeida commented on a change in pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
tomasalmeida commented on a change in pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r560506725



##########
File path: src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##########
@@ -0,0 +1,106 @@
+/*

Review comment:
       Thank you for the feedback! I will rework on this PR and reimplement the binding using the references given. I believe it is straightforward to implement it for NodeNameGenerator, SlingPostProcessor and PostResponseCreator lists.
   
   Although, I need to rethink how to bind/unbind the postOperation based on OperationName, as in the implementation we have a Map(operationName, List of PostOperation services). Having one large list is not optimal and the map was useful.
   
   If any of you have an idea how I can solve the map problem, I accept suggestions 😄 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] removed a comment on pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-763591257


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='82.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list) [82.4% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-763591257


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='82.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list) [82.4% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] paul-bjorkstrand commented on a change in pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
paul-bjorkstrand commented on a change in pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r559228997



##########
File path: src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##########
@@ -0,0 +1,106 @@
+/*

Review comment:
       This looks like it could be replaced with an implementation of [SortedMap] rather than a new, custom class. A benefit of using a SortedMap is that you can use either a concurrency safe version or not, depending on the use case.
   
   [SortedMap]: https://docs.oracle.com/javase/8/docs/api/java/util/SortedMap.html




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] kwin commented on a change in pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r560063474



##########
File path: src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##########
@@ -0,0 +1,106 @@
+/*

Review comment:
       Please rather use DS field injection which orders automatically by ranking
   
   > For a reference with multiple cardinality, a field must be a collection of one of the following types:
   Collection
   List
   A subtype of Collection - This type can only be used for dynamic references using the update reference field option. The component instance must initialize the field to a collection object in its constructor.
   (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-field.injection)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #10: SLING-10030 - Addin PostOperation ranking

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#issuecomment-768270598


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='82.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list) [82.4% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=10&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org