You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Dominik Lienemann (JIRA)" <ji...@apache.org> on 2016/03/15 15:59:33 UTC

[jira] [Created] (SLING-5610) ResourceUtil.getValueMap() contains a wrong @Nonnull annotation

Dominik Lienemann created SLING-5610:
----------------------------------------

             Summary: ResourceUtil.getValueMap() contains a wrong @Nonnull annotation 
                 Key: SLING-5610
                 URL: https://issues.apache.org/jira/browse/SLING-5610
             Project: Sling
          Issue Type: Bug
          Components: API
    Affects Versions: API 2.9.0
            Reporter: Dominik Lienemann


*org.apache.sling.api.resource.ResourceUtil.getValueMap(res)* performs a null check as first action (*if ( res == null ) {*). Also, the javadoc states that this method is null safe.

But the method contains a @Nonnull annotation for the res parameter (*@Nonnull final Resource res*) which forces the calling methods to do an additional null check, even if the method handles it internally.

I suggest to remove the annotation for the parameter.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)