You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wayang.apache.org by GitBox <gi...@apache.org> on 2022/04/20 00:00:21 UTC
[GitHub] [incubator-wayang] regaleo605 opened a new pull request, #224: Added more test for issue 134
regaleo605 opened a new pull request, #224:
URL: https://github.com/apache/incubator-wayang/pull/224
For the FlinkDistinctOperatorTest there was an Assertion error so the distinct operator may not work as intended to be.
However for the FlinkJoinOperatorTest and FlinkReduceByTest, there were an IllegalArgumentExceptionError. Is it because of my local machine or for join and reduce operators there are other things to consider when coding the test?
Other than that, other tests work fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] berttty commented on a diff in pull request #224: Added more test for issue 134
Posted by GitBox <gi...@apache.org>.
berttty commented on code in PR #224:
URL: https://github.com/apache/incubator-wayang/pull/224#discussion_r854054605
##########
wayang-platforms/wayang-flink/code/test/java/org/apache/wayang/flink/operators/FlinkReduceByOperatorTest.java:
##########
@@ -0,0 +1,70 @@
+package org.apache.wayang.flink.operators;
Review Comment:
This file is missing the header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] 2pk03 commented on a diff in pull request #224: Added more test for issue 134
Posted by GitBox <gi...@apache.org>.
2pk03 commented on code in PR #224:
URL: https://github.com/apache/incubator-wayang/pull/224#discussion_r854324435
##########
wayang-platforms/wayang-flink/code/test/java/org/apache/wayang/flink/operators/FlinkReduceByOperatorTest.java:
##########
@@ -0,0 +1,70 @@
+package org.apache.wayang.flink.operators;
+
Review Comment:
```
/*
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
```
##########
wayang-platforms/wayang-flink/code/test/java/org/apache/wayang/flink/operators/FlinkReduceByOperatorTest.java:
##########
@@ -0,0 +1,70 @@
+package org.apache.wayang.flink.operators;
+
Review Comment:
pls insert the license header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] berttty commented on pull request #224: Added more test for issue 134
Posted by GitBox <gi...@apache.org>.
berttty commented on PR #224:
URL: https://github.com/apache/incubator-wayang/pull/224#issuecomment-1103856355
I will take a look at the operator that you mentioned may the problem can be with the selection of the key, but I will double-check it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] 2pk03 commented on pull request #224: Added more test for issue 134
Posted by GitBox <gi...@apache.org>.
2pk03 commented on PR #224:
URL: https://github.com/apache/incubator-wayang/pull/224#issuecomment-1113279175
Hi @regaleo605 - can you please add the missing header so we can commit? Thanks a lot :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] regaleo605 commented on pull request #224: Added more test for issue 134
Posted by GitBox <gi...@apache.org>.
regaleo605 commented on PR #224:
URL: https://github.com/apache/incubator-wayang/pull/224#issuecomment-1113905226
Sorry about that, I was a bit busy and have not resolved the runtime IllegalArgumentException error. I added the header and license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] berttty commented on pull request #224: Added more test for issue 134
Posted by GitBox <gi...@apache.org>.
berttty commented on PR #224:
URL: https://github.com/apache/incubator-wayang/pull/224#issuecomment-1114341607
> Everything look ok
The test that is not valid is part of bug in the code, I will take care of it 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-wayang] berttty merged pull request #224: Added more test for issue 134
Posted by GitBox <gi...@apache.org>.
berttty merged PR #224:
URL: https://github.com/apache/incubator-wayang/pull/224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org