You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/17 18:59:05 UTC
[GitHub] [airflow] bbovenzi opened a new pull request #19661: Revert "Copy AppBuilder Base class verbatim from FAB to Airflow"
bbovenzi opened a new pull request #19661:
URL: https://github.com/apache/airflow/pull/19661
Somehow the AppBuilder class changes broke the UI. This reverts that change for now until there is a fix.
This reverts commit 37a12e9c278209d7e8ea914012a31a91a6c6ccff.
Closes: #19647
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19661: Revert "Copy AppBuilder Base class verbatim from FAB to Airflow"
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19661:
URL: https://github.com/apache/airflow/pull/19661#issuecomment-971883291
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19661: Revert "Copy AppBuilder Base class verbatim from FAB to Airflow"
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19661:
URL: https://github.com/apache/airflow/pull/19661#issuecomment-971895869
Good call :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #19661: Revert "Copy AppBuilder Base class verbatim from FAB to Airflow"
Posted by GitBox <gi...@apache.org>.
bbovenzi merged pull request #19661:
URL: https://github.com/apache/airflow/pull/19661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org