Re: [PR] Core: add JSON serialization for BaseFilesTable.ManifestReadTask, AllManifestsTable.ManifestListReadTask, and BaseEntriesTable.ManifestReadTask [iceberg]

["stevenzwu (via GitHub)" <gi...@apache.org>]

stevenzwu commented on code in PR #10735:
URL: https://github.com/apache/iceberg/pull/10735#discussion_r1685644489


##########
core/src/main/java/org/apache/iceberg/BaseEntriesTable.java:
##########
@@ -304,11 +306,6 @@ static class ManifestReadTask extends BaseFileScanTask implements DataTask {
               : new Schema();
     }
 
-    @VisibleForTesting

Review Comment:
   not just for testing anymore. JSON parser needs this getter too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org