You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/14 14:08:01 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #7172: ARROW-8763: [C++] Add RandomAccessFile::WillNeed

pitrou commented on a change in pull request #7172:
URL: https://github.com/apache/arrow/pull/7172#discussion_r425165237



##########
File path: cpp/src/arrow/io/caching.cc
##########
@@ -171,7 +171,8 @@ Status ReadRangeCache::Cache(std::vector<ReadRange> ranges) {
   }
 
   impl_->AddEntries(std::move(entries));
-  return Status::OK();
+  // Prefetch immediately, regardless of executor availability, if possible
+  return impl_->file->WillNeed(ranges);

Review comment:
       `ReadAsync` by default only queues the read for execution in a thread pool. It doesn't necessarily issue the read immediately. So this might still be useful, though perhaps only in uninteresting corner cases.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org