[GitHub] michaelandrepearce commented on a change in pull request #2547: Patched with live lock evaluation

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #2547: Patched with live lock evaluation
URL: https://github.com/apache/activemq-artemis/pull/2547#discussion_r255168020
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java
 ##########
 @@ -338,5 +345,104 @@ protected FileLock lock(final long lockPosition) throws Exception {
       while (lock == null);
       return lock;
    }
+   
+   private void startLockMonitoring()	{
+	   logger.debug("Starting the lock monitor");
+	   Thread monitorThread = new Thread(new MonitorLock());
 
 Review comment:
   We have thread executors. It is important it must use these. Also this solution uses up a thread permanently which goes agaisnt some of the thread modelling. Look maybe to use schedule thread executor 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services