svn commit: r779914 - /tomcat/current/tc5.5.x/STATUS.txt

[kk...@apache.org]

Author: kkolinko
Date: Fri May 29 10:22:02 2009
New Revision: 779914

URL: http://svn.apache.org/viewvc?rev=779914&view=rev
Log:
vote and proposal

Modified:
    tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=779914&r1=779913&r2=779914&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Fri May 29 10:22:02 2009
@@ -121,8 +121,20 @@
   Make access log valves thread safe
   http://people.apache.org/~markt/patches/2009-02-04-bug38483.patch
   +1: markt, rjung
+  +1: kkolinko (ok, but I propose an additional patch below)
   -1: 
 
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38483
+  Make access log valves thread safe (part 2)
+  (It is an addition to markts' 2009-02-04-bug38483.patch that is proposed above)
+  The dateFormatter that is used for log file rotation also needs its syncs.
+  The sync block scope is wide, because rotationLastChecked assignment is also
+  not safe: long and pointer assignments are not atomic.
+  It also allows us to get rid of double checks for tsDate.
+  http://people.apache.org/~kkolinko/patches/2009-05-29_bug38483_2.patch
+  +1: kkolinko
+  -1:
+
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38553
   Return 401 rather than 400 if client presents no certs for CLIENT-CERT auth
   http://svn.apache.org/viewvc?rev=740684&view=rev



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org