You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lc...@apache.org on 2018/01/19 23:52:56 UTC
[beam] 04/04: CR: fix comments
This is an automated email from the ASF dual-hosted git repository.
lcwik pushed a commit to branch go-sdk
in repository https://gitbox.apache.org/repos/asf/beam.git
commit e019f199cca2e98f9dc8e544d5e2c6796b1be3dc
Author: Henning Rohde <he...@google.com>
AuthorDate: Fri Jan 19 15:45:48 2018 -0800
CR: fix comments
---
sdks/go/pkg/beam/core/runtime/exec/encode.go | 2 +-
sdks/go/pkg/beam/core/util/reflectx/call.go | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/sdks/go/pkg/beam/core/runtime/exec/encode.go b/sdks/go/pkg/beam/core/runtime/exec/encode.go
index 2940578..7f6bbee 100644
--- a/sdks/go/pkg/beam/core/runtime/exec/encode.go
+++ b/sdks/go/pkg/beam/core/runtime/exec/encode.go
@@ -30,7 +30,7 @@ type Encoder interface {
}
func makeEncoder(fn reflectx.Func) Encoder {
- // Detect one of the valid decoder forms and allow it to be invoked
+ // Detect one of the valid encoder forms and allow it to be invoked
// efficiently, relying on the general reflectx.Func framework for
// avoiding expensive reflection calls. There are 4 forms:
//
diff --git a/sdks/go/pkg/beam/core/util/reflectx/call.go b/sdks/go/pkg/beam/core/util/reflectx/call.go
index d011ec5..fbca8e3 100644
--- a/sdks/go/pkg/beam/core/util/reflectx/call.go
+++ b/sdks/go/pkg/beam/core/util/reflectx/call.go
@@ -45,8 +45,8 @@ var (
funcsMu sync.Mutex
)
-// RegisterFunc registers an custom reflectFunc factory for the given type, such as
-// "func(int)bool". If multiple func factories are registered for the same type,
+// RegisterFunc registers an custom Func factory for the given type, such as
+// "func(int)bool". If multiple Func factories are registered for the same type,
// the last registration wins.
func RegisterFunc(t reflect.Type, maker func(interface{}) Func) {
funcsMu.Lock()
@@ -59,7 +59,7 @@ func RegisterFunc(t reflect.Type, maker func(interface{}) Func) {
funcs[key] = maker
}
-// MakeFunc returns a reflectFunc for given function.
+// MakeFunc returns a Func for given function.
func MakeFunc(fn interface{}) Func {
funcsMu.Lock()
maker, exists := funcs[reflect.TypeOf(fn).String()]
--
To stop receiving notification emails like this one, please contact
"commits@beam.apache.org" <co...@beam.apache.org>.