You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/24 13:06:23 UTC
[GitHub] [camel-k-runtime] lburgazzoli opened a new issue #453: knative: refactor knative environment definition
lburgazzoli opened a new issue #453:
URL: https://github.com/apache/camel-k-runtime/issues/453
As today the knative json definition looks like:
```json
{
"services": [
{
"type": "channel|endpoint|event", <1>
"name": "", <2>
"host": "", <3>
"port": "", <3>
"metadata": {
"service.path": "",
"service.url" : ""
"filter.header": "value",
"knative.event.type": "",
"knative.kind": "",
"knative.apiVersion": "",
"camel.endpoint.kind": "source|sink",
"ce.override.ce-type": "something",
}
}, {
...
}
]
}
```
but:
1. to avoid confusion, the `services` array should be renamed to `resources`
2. to make the component transport agnostic, host and port should be deprecated and removed
3. `service.url"` should be promoted as field used to describe the target resource
4. `service.path` should be removed
We can keep the fields still presents for a release cycle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #453: knative: refactor knative environment definition
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #453:
URL: https://github.com/apache/camel-k-runtime/issues/453#issuecomment-696336252
> Everything ok, except renaming endpoint to service because endpoint can be used not only with (Knative) service but with any kind of endpoint.
>
What other endpoint do you have in mind ?
> Is service.url already supported?
Yes, I think you are already setting it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #453: knative: refactor knative environment definition
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #453:
URL: https://github.com/apache/camel-k-runtime/issues/453#issuecomment-696336252
> Everything ok, except renaming endpoint to service because endpoint can be used not only with (Knative) service but with any kind of endpoint.
>
What other endpoint do you have in mind ?
> Is service.url already supported?
Yes, I think you are already setting it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli closed issue #453: knative: refactor knative environment definition
Posted by GitBox <gi...@apache.org>.
lburgazzoli closed issue #453:
URL: https://github.com/apache/camel-k-runtime/issues/453
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #453: knative: refactor knative environment definition
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #453:
URL: https://github.com/apache/camel-k-runtime/issues/453#issuecomment-696841862
So `service.path` can't be removed as may be needed to set the listening path as when using the `platform-http` there may be a risk to clash with other services being exposed on the same port
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #453: knative: refactor knative environment definition
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #453:
URL: https://github.com/apache/camel-k-runtime/issues/453#issuecomment-679114902
@nicolaferraro does it make sense for you ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] nicolaferraro commented on issue #453: knative: refactor knative environment definition
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on issue #453:
URL: https://github.com/apache/camel-k-runtime/issues/453#issuecomment-696335267
Everything ok, except renaming endpoint to service because endpoint can be used not only with (Knative) service but with any kind of endpoint.
Is service.url already supported?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] nicolaferraro commented on issue #453: knative: refactor knative environment definition
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on issue #453:
URL: https://github.com/apache/camel-k-runtime/issues/453#issuecomment-696335267
Everything ok, except renaming endpoint to service because endpoint can be used not only with (Knative) service but with any kind of endpoint.
Is service.url already supported?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #453: knative: refactor knative environment definition
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #453:
URL: https://github.com/apache/camel-k-runtime/issues/453#issuecomment-696841862
So `service.path` can't be removed as may be needed to set the listening path as when using the `platform-http` there may be a risk to clash with other services being exposed on the same port
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org