You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/07/19 11:10:01 UTC
[GitHub] flink pull request #6373: [FLINK-9838][logging] Don't log slot request failu...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6373
[FLINK-9838][logging] Don't log slot request failures on the ResourceManager
## What is the purpose of the change
Decrease log cluttering by not logging slot request failures on the `ResourceManager`.
## Verifying this change
- Verified manually
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixSlotAllocationFailureLogging
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6373.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6373
----
commit f02f0231ba1fe047086fdf90227bf4dac9697d87
Author: Till Rohrmann <tr...@...>
Date: 2018-07-19T11:07:44Z
[FLINK-9838][logging] Don't log slot request failures on the ResourceManager
----
---
[GitHub] flink issue #6373: [FLINK-9838][logging] Don't log slot request failures on ...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6373
+1
---
[GitHub] flink pull request #6373: [FLINK-9838][logging] Don't log slot request failu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6373
---
[GitHub] flink issue #6373: [FLINK-9838][logging] Don't log slot request failures on ...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/6373
Ran into this bug too.
+1 for the fix
---
[GitHub] flink issue #6373: [FLINK-9838][logging] Don't log slot request failures on ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6373
Thanks for the review @yanghua and @bowenli86. Merging this PR.
---