You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/09/20 00:21:33 UTC

[kudu-CR] [docs] add info on rebalancer's --report-only flag

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11479


Change subject: [docs] add info on rebalancer's --report-only flag
......................................................................

[docs] add info on rebalancer's --report-only flag

Documented the --report-only command-line flag for the rebalancer
kudu CLI tool.  Documented the --output_replica_distribution_details
flag as well.

This is a follow-up to f6668ecac27492cbe6ba7682beff6d347650d689.

Change-Id: I80265eba61c347f70680636f32e0b80ee90ee59f
---
M docs/administration.adoc
1 file changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/11479/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I80265eba61c347f70680636f32e0b80ee90ee59f
Gerrit-Change-Number: 11479
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [docs] add info on rebalancer's --report-only flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11479 )

Change subject: [docs] add info on rebalancer's --report-only flag
......................................................................

[docs] add info on rebalancer's --report-only flag

Documented the --report-only command-line flag for the rebalancer
kudu CLI tool.  Documented the --output_replica_distribution_details
flag as well.

This is a follow-up to f6668ecac27492cbe6ba7682beff6d347650d689.

Change-Id: I80265eba61c347f70680636f32e0b80ee90ee59f
Reviewed-on: http://gerrit.cloudera.org:8080/11479
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M docs/administration.adoc
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Will Berkeley: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/11479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I80265eba61c347f70680636f32e0b80ee90ee59f
Gerrit-Change-Number: 11479
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [docs] add info on rebalancer's --report-only flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11479 )

Change subject: [docs] add info on rebalancer's --report-only flag
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/11479/1/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/11479/1/docs/administration.adoc@1183
PS1, Line 1183: stats
> nit: statistics
Done


http://gerrit.cloudera.org:8080/#/c/11479/1/docs/administration.adoc@1183
PS1, Line 1183: output
> "print" instead of "output" since the "output" is easy to wrongly parse as 
Done


http://gerrit.cloudera.org:8080/#/c/11479/1/docs/administration.adoc@1187
PS1, Line 1187: stats
> nit:statistics
Done


http://gerrit.cloudera.org:8080/#/c/11479/1/docs/administration.adoc@1186
PS1, Line 1186: It's possible to get a report on table- and cluster-wide replica distribution
              : stats without starting any rebalancing activity. Use the `--report_only` flag
              : for that.
> Simplify slightly to
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80265eba61c347f70680636f32e0b80ee90ee59f
Gerrit-Change-Number: 11479
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 17:24:15 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] add info on rebalancer's --report-only flag

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11479 )

Change subject: [docs] add info on rebalancer's --report-only flag
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/11479/1/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/11479/1/docs/administration.adoc@1183
PS1, Line 1183: output
"print" instead of "output" since the "output" is easy to wrongly parse as a noun in this context. Every time I read it I make this mistake and have to backtrack and re-parse.


http://gerrit.cloudera.org:8080/#/c/11479/1/docs/administration.adoc@1183
PS1, Line 1183: stats
nit: statistics


http://gerrit.cloudera.org:8080/#/c/11479/1/docs/administration.adoc@1187
PS1, Line 1187: stats
nit:statistics


http://gerrit.cloudera.org:8080/#/c/11479/1/docs/administration.adoc@1186
PS1, Line 1186: It's possible to get a report on table- and cluster-wide replica distribution
              : stats without starting any rebalancing activity. Use the `--report_only` flag
              : for that.
Simplify slightly to

"Use the `--report_only` flag to get a report on table- and cluster-wide replica distribution statistics without starting any rebalancing activity."



-- 
To view, visit http://gerrit.cloudera.org:8080/11479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80265eba61c347f70680636f32e0b80ee90ee59f
Gerrit-Change-Number: 11479
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 16:53:47 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] add info on rebalancer's --report-only flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11479 )

Change subject: [docs] add info on rebalancer's --report-only flag
......................................................................


Patch Set 1: Verified+1

Unrelated fluke in ASAN build:

17:41:28 ln: failed to access '/home/jenkins-slave/workspace/kudu-master/0/build/asan/bin/hive-home': Not a directory
17:41:28 ln: failed to access '/home/jenkins-slave/workspace/kudu-master/0/build/asan/bin/hadoop-home': Not a directory
17:41:28 ln: failed to access '/home/jenkins-slave/workspace/kudu-master/0/build/asan/bin/java-home': Not a directory
17:41:28 CMake Error at thirdparty/installed/common/share/cmake-3.9/Modules/UseJava.cmake:609 (file):
17:41:28   file failed to open for writing (Not a directory):
17:41:28 
17:41:28     /home/jenkins-slave/workspace/kudu-master/0/build/asan/bin/CMakeFiles/hms-plugin.dir/java_sources
17:41:28 Call Stack (most recent call first):
17:41:28   src/kudu/hms/CMakeLists.txt:68 (add_jar)


-- 
To view, visit http://gerrit.cloudera.org:8080/11479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80265eba61c347f70680636f32e0b80ee90ee59f
Gerrit-Change-Number: 11479
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 02:37:36 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] add info on rebalancer's --report-only flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/11479 )

Change subject: [docs] add info on rebalancer's --report-only flag
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/11479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I80265eba61c347f70680636f32e0b80ee90ee59f
Gerrit-Change-Number: 11479
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [docs] add info on rebalancer's --report-only flag

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11479 )

Change subject: [docs] add info on rebalancer's --report-only flag
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80265eba61c347f70680636f32e0b80ee90ee59f
Gerrit-Change-Number: 11479
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 18:02:26 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] add info on rebalancer's --report-only flag

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11479

to look at the new patch set (#2).

Change subject: [docs] add info on rebalancer's --report-only flag
......................................................................

[docs] add info on rebalancer's --report-only flag

Documented the --report-only command-line flag for the rebalancer
kudu CLI tool.  Documented the --output_replica_distribution_details
flag as well.

This is a follow-up to f6668ecac27492cbe6ba7682beff6d347650d689.

Change-Id: I80265eba61c347f70680636f32e0b80ee90ee59f
---
M docs/administration.adoc
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/11479/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I80265eba61c347f70680636f32e0b80ee90ee59f
Gerrit-Change-Number: 11479
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>