You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/08 14:41:32 UTC
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17369: fix: Database selector overflow
zhaoyongjie commented on a change in pull request #17369:
URL: https://github.com/apache/superset/pull/17369#discussion_r744788849
##########
File path: superset-frontend/src/components/TimezoneSelector/TimezoneSelector.test.tsx
##########
@@ -54,9 +54,7 @@ describe('TimezoneSelector', () => {
});
expect(select).toBeInTheDocument();
userEvent.click(select);
- const selection = await screen.findByTitle(
- 'GMT -06:00 (Mountain Daylight Time)',
- );
+ const selection = await screen.findByTitle('GMT -06:00 (America/Belize)');
Review comment:
we should coverage "offsetsToName" in `src/components/TimezoneSelector/index.tsx`. I have a seprate [PR](https://github.com/apache/superset/pull/17370) do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org