You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Jim Yu (JIRA)" <ji...@apache.org> on 2009/04/14 05:03:14 UTC
[jira] Created: (HARMONY-6150) [classlib][luni] Move ScannerTest
out of the exclude list
[classlib][luni] Move ScannerTest out of the exclude list
---------------------------------------------------------
Key: HARMONY-6150
URL: https://issues.apache.org/jira/browse/HARMONY-6150
Project: Harmony
Issue Type: Bug
Components: Classlib
Affects Versions: 5.0M9
Reporter: Jim Yu
Currently, we have three testcase failures for Scanner. Fortunately, there is only one failing testcase which is caused by Scanner itself. And I've already got a fix for that failure and raised a JIRA HARMONY-6147 for it . The other two [1] are caused by DecimalFormat instance for Locale("ar", "AE") which rely on text module. After applying the patch of HARMONY-6147, we can comment the failing part of these two testcase and add a note there. Then we can move the ScannerTest out of the exclude list safely.
[1]
test_nextFloat()
test_hasNextFloat()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6150) [classlib][luni] Move ScannerTest
out of the exclude list
Posted by "Jim Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Yu updated HARMONY-6150:
----------------------------
Attachment: HARMONY-6150.diff
This patch would move ScannerTest out of exclude list safely.
> [classlib][luni] Move ScannerTest out of the exclude list
> ---------------------------------------------------------
>
> Key: HARMONY-6150
> URL: https://issues.apache.org/jira/browse/HARMONY-6150
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M9
> Reporter: Jim Yu
> Attachments: HARMONY-6150.diff
>
>
> Currently, we have three testcase failures for Scanner. Fortunately, there is only one failing testcase which is caused by Scanner itself. And I've already got a fix for that failure and raised a JIRA HARMONY-6147 for it . The other two [1] are caused by DecimalFormat instance for Locale("ar", "AE") which rely on text module. After applying the patch of HARMONY-6147, we can comment the failing part of these two testcase and add a note there. Then we can move the ScannerTest out of the exclude list safely.
> [1]
> test_nextFloat()
> test_hasNextFloat()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6150) [classlib][luni] Move ScannerTest
out of the exclude list
Posted by "Jim Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699128#action_12699128 ]
Jim Yu commented on HARMONY-6150:
---------------------------------
Hi Tim,
They are obsolete ones. Since these commented tests are ICU relevant issues, I think they were originally written according to the behavior of ICU with old version. As ICU has been upgraded for several times, they became obsolete now. However, we didn't notice these changes as ScannerTest is in the exclude list. I think we can comment them temporarily and update them when ICU 4.0 upgrade is done.
> [classlib][luni] Move ScannerTest out of the exclude list
> ---------------------------------------------------------
>
> Key: HARMONY-6150
> URL: https://issues.apache.org/jira/browse/HARMONY-6150
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M9
> Reporter: Jim Yu
> Attachments: HARMONY-6150.diff
>
>
> Currently, we have three testcase failures for Scanner. Fortunately, there is only one failing testcase which is caused by Scanner itself. And I've already got a fix for that failure and raised a JIRA HARMONY-6147 for it . The other two [1] are caused by DecimalFormat instance for Locale("ar", "AE") which rely on text module. After applying the patch of HARMONY-6147, we can comment the failing part of these two testcase and add a note there. Then we can move the ScannerTest out of the exclude list safely.
> [1]
> test_nextFloat()
> test_hasNextFloat()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6150) [classlib][luni] Move ScannerTest
out of the exclude list
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison updated HARMONY-6150:
---------------------------------
Fix Version/s: 5.0M10
> [classlib][luni] Move ScannerTest out of the exclude list
> ---------------------------------------------------------
>
> Key: HARMONY-6150
> URL: https://issues.apache.org/jira/browse/HARMONY-6150
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M9
> Reporter: Jim Yu
> Assignee: Tim Ellison
> Fix For: 5.0M10
>
> Attachments: HARMONY-6150.diff
>
>
> Currently, we have three testcase failures for Scanner. Fortunately, there is only one failing testcase which is caused by Scanner itself. And I've already got a fix for that failure and raised a JIRA HARMONY-6147 for it . The other two [1] are caused by DecimalFormat instance for Locale("ar", "AE") which rely on text module. After applying the patch of HARMONY-6147, we can comment the failing part of these two testcase and add a note there. Then we can move the ScannerTest out of the exclude list safely.
> [1]
> test_nextFloat()
> test_hasNextFloat()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-6150) [classlib][luni] Move ScannerTest out
of the exclude list
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison closed HARMONY-6150.
--------------------------------
> [classlib][luni] Move ScannerTest out of the exclude list
> ---------------------------------------------------------
>
> Key: HARMONY-6150
> URL: https://issues.apache.org/jira/browse/HARMONY-6150
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M9
> Reporter: Jim Yu
> Assignee: Tim Ellison
> Attachments: HARMONY-6150.diff
>
>
> Currently, we have three testcase failures for Scanner. Fortunately, there is only one failing testcase which is caused by Scanner itself. And I've already got a fix for that failure and raised a JIRA HARMONY-6147 for it . The other two [1] are caused by DecimalFormat instance for Locale("ar", "AE") which rely on text module. After applying the patch of HARMONY-6147, we can comment the failing part of these two testcase and add a note there. Then we can move the ScannerTest out of the exclude list safely.
> [1]
> test_nextFloat()
> test_hasNextFloat()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6150) [classlib][luni] Move ScannerTest
out of the exclude list
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699118#action_12699118 ]
Tim Ellison commented on HARMONY-6150:
--------------------------------------
Why are there two tests that are commented out by this patch?
If they are valid tests then we should fix the implementation, and if they are invalid tests then remove them completely.
The comment says the tests fail on the RI, so maybe they are invalid tests?
> [classlib][luni] Move ScannerTest out of the exclude list
> ---------------------------------------------------------
>
> Key: HARMONY-6150
> URL: https://issues.apache.org/jira/browse/HARMONY-6150
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M9
> Reporter: Jim Yu
> Attachments: HARMONY-6150.diff
>
>
> Currently, we have three testcase failures for Scanner. Fortunately, there is only one failing testcase which is caused by Scanner itself. And I've already got a fix for that failure and raised a JIRA HARMONY-6147 for it . The other two [1] are caused by DecimalFormat instance for Locale("ar", "AE") which rely on text module. After applying the patch of HARMONY-6147, we can comment the failing part of these two testcase and add a note there. Then we can move the ScannerTest out of the exclude list safely.
> [1]
> test_nextFloat()
> test_hasNextFloat()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6150) [classlib][luni] Move ScannerTest
out of the exclude list
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison updated HARMONY-6150:
---------------------------------
Issue Type: Test (was: Bug)
> [classlib][luni] Move ScannerTest out of the exclude list
> ---------------------------------------------------------
>
> Key: HARMONY-6150
> URL: https://issues.apache.org/jira/browse/HARMONY-6150
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Affects Versions: 5.0M9
> Reporter: Jim Yu
> Assignee: Tim Ellison
> Fix For: 5.0M10
>
> Attachments: HARMONY-6150.diff
>
>
> Currently, we have three testcase failures for Scanner. Fortunately, there is only one failing testcase which is caused by Scanner itself. And I've already got a fix for that failure and raised a JIRA HARMONY-6147 for it . The other two [1] are caused by DecimalFormat instance for Locale("ar", "AE") which rely on text module. After applying the patch of HARMONY-6147, we can comment the failing part of these two testcase and add a note there. Then we can move the ScannerTest out of the exclude list safely.
> [1]
> test_nextFloat()
> test_hasNextFloat()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6150) [classlib][luni] Move ScannerTest
out of the exclude list
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison resolved HARMONY-6150.
----------------------------------
Resolution: Fixed
Jim,
I applied a modified version of the patch at repo revision r765125 since I had to comment out more failing tests all related to the same Locale("ar", "AE").
If you verify this patch then we can open a new JIRA to re-enable those individual tests.
> [classlib][luni] Move ScannerTest out of the exclude list
> ---------------------------------------------------------
>
> Key: HARMONY-6150
> URL: https://issues.apache.org/jira/browse/HARMONY-6150
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M9
> Reporter: Jim Yu
> Assignee: Tim Ellison
> Attachments: HARMONY-6150.diff
>
>
> Currently, we have three testcase failures for Scanner. Fortunately, there is only one failing testcase which is caused by Scanner itself. And I've already got a fix for that failure and raised a JIRA HARMONY-6147 for it . The other two [1] are caused by DecimalFormat instance for Locale("ar", "AE") which rely on text module. After applying the patch of HARMONY-6147, we can comment the failing part of these two testcase and add a note there. Then we can move the ScannerTest out of the exclude list safely.
> [1]
> test_nextFloat()
> test_hasNextFloat()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6150) [classlib][luni] Move ScannerTest
out of the exclude list
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699163#action_12699163 ]
Tim Ellison commented on HARMONY-6150:
--------------------------------------
Sorry Jim, ignore that last comment. I ignored the same two tests as you...!
> [classlib][luni] Move ScannerTest out of the exclude list
> ---------------------------------------------------------
>
> Key: HARMONY-6150
> URL: https://issues.apache.org/jira/browse/HARMONY-6150
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M9
> Reporter: Jim Yu
> Assignee: Tim Ellison
> Attachments: HARMONY-6150.diff
>
>
> Currently, we have three testcase failures for Scanner. Fortunately, there is only one failing testcase which is caused by Scanner itself. And I've already got a fix for that failure and raised a JIRA HARMONY-6147 for it . The other two [1] are caused by DecimalFormat instance for Locale("ar", "AE") which rely on text module. After applying the patch of HARMONY-6147, we can comment the failing part of these two testcase and add a note there. Then we can move the ScannerTest out of the exclude list safely.
> [1]
> test_nextFloat()
> test_hasNextFloat()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6150) [classlib][luni] Move ScannerTest
out of the exclude list
Posted by "Jim Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699509#action_12699509 ]
Jim Yu commented on HARMONY-6150:
---------------------------------
Verified at r765456. Thanks, Tim. I will raise new JIRA to track these commented out obsolete tests.
> [classlib][luni] Move ScannerTest out of the exclude list
> ---------------------------------------------------------
>
> Key: HARMONY-6150
> URL: https://issues.apache.org/jira/browse/HARMONY-6150
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M9
> Reporter: Jim Yu
> Assignee: Tim Ellison
> Attachments: HARMONY-6150.diff
>
>
> Currently, we have three testcase failures for Scanner. Fortunately, there is only one failing testcase which is caused by Scanner itself. And I've already got a fix for that failure and raised a JIRA HARMONY-6147 for it . The other two [1] are caused by DecimalFormat instance for Locale("ar", "AE") which rely on text module. After applying the patch of HARMONY-6147, we can comment the failing part of these two testcase and add a note there. Then we can move the ScannerTest out of the exclude list safely.
> [1]
> test_nextFloat()
> test_hasNextFloat()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6150) [classlib][luni] Move ScannerTest
out of the exclude list
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison reassigned HARMONY-6150:
------------------------------------
Assignee: Tim Ellison
> [classlib][luni] Move ScannerTest out of the exclude list
> ---------------------------------------------------------
>
> Key: HARMONY-6150
> URL: https://issues.apache.org/jira/browse/HARMONY-6150
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M9
> Reporter: Jim Yu
> Assignee: Tim Ellison
> Attachments: HARMONY-6150.diff
>
>
> Currently, we have three testcase failures for Scanner. Fortunately, there is only one failing testcase which is caused by Scanner itself. And I've already got a fix for that failure and raised a JIRA HARMONY-6147 for it . The other two [1] are caused by DecimalFormat instance for Locale("ar", "AE") which rely on text module. After applying the patch of HARMONY-6147, we can comment the failing part of these two testcase and add a note there. Then we can move the ScannerTest out of the exclude list safely.
> [1]
> test_nextFloat()
> test_hasNextFloat()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.