[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #6054: [RELAY][MXNET][FRONTEND] add support for MXNET numpy operators

[GitBox <gi...@apache.org>]

yzhliu commented on a change in pull request #6054:
URL: https://github.com/apache/incubator-tvm/pull/6054#discussion_r456653234



##########
File path: tests/python/frontend/mxnet/test_forward.py
##########
@@ -1350,7 +1351,7 @@ def verify(batch, seq_length, num_heads, head_dim):
     verify(1, 10, 4, 16)
     verify(3, 10, 6, 8)
 
-
+    

Review comment:
       remove the change

##########
File path: tests/python/frontend/mxnet/test_forward.py
##########
@@ -1373,6 +1374,266 @@ def verify(data_shape, anchor_shape, stds=[1, 1, 1, 1], clip=-1, in_format="corn
     verify((1, 10, 4), (1, 10, 4), in_format="center")
 
 
+dtype_list = ['float64', 'float32', 'int64', 'int32', 'bool']
+
+def test_forward_npi_pad():
+    if not hasattr(mx.sym.np, 'pad'):
+        pytest.skip("mx.sym.np.pad hasn't been publish yet")
+
+    def verify(data_shape, mode, pad_width, constant_value=0.0):
+        for dtype in dtype_list:

Review comment:
       would it be easier to use `@pytest.mark.parametrize`?

##########
File path: tests/python/frontend/mxnet/test_forward.py
##########
@@ -1449,3 +1710,13 @@ def verify(data_shape, anchor_shape, stds=[1, 1, 1, 1], clip=-1, in_format="corn
     test_forward_box_decode()
     test_forward_amp_multicast()
     test_forward_amp_cast()
+    test_forward_npi_pad()
+    test_forward_npi_transpose()
+    test_forward_npi_concatenate()
+    test_forward_np_copy()
+    test_forward_npx_reshape()
+    test_forward_npi_binary()
+    test_forward_npi_binary_scalar()
+    test_forward_npi_tanh()
+    test_forward_npi_where_rscalar()
+    test_forward_split_v2()

Review comment:
       maybe we can just do `pytest.main([__file__])`

##########
File path: tests/python/frontend/mxnet/test_forward.py
##########
@@ -1373,6 +1374,266 @@ def verify(data_shape, anchor_shape, stds=[1, 1, 1, 1], clip=-1, in_format="corn
     verify((1, 10, 4), (1, 10, 4), in_format="center")
 
 
+dtype_list = ['float64', 'float32', 'int64', 'int32', 'bool']
+
+def test_forward_npi_pad():
+    if not hasattr(mx.sym.np, 'pad'):
+        pytest.skip("mx.sym.np.pad hasn't been publish yet")

Review comment:
       do we need to update CI's mxnet version?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org