You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/30 10:01:32 UTC
[GitHub] [hbase] Apache9 opened a new pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Apache9 opened a new pull request #1811:
URL: https://github.com/apache/hbase/pull/1811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#discussion_r433584900
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1563,7 +1564,7 @@ protected void stopServiceThreads() {
private void createProcedureExecutor() throws IOException {
MasterProcedureEnv procEnv = new MasterProcedureEnv(this);
procedureStore =
- new RegionProcedureStore(this, localStore, new MasterProcedureEnv.FsUtilsLeaseRecovery(this));
+ new RegionProcedureStore(this, masterRegion, new MasterProcedureEnv.FsUtilsLeaseRecovery(this));
Review comment:
The idea is to use different families. There is a known risk that, if someone stores a lot data in one of the families, it will slow down the start up of the whole HMaster, even if it is not necessary. We should document this in our ref guide. Can be a follow on issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#issuecomment-636337403
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 50s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 37s | master passed |
| +1 :green_heart: | compile | 1m 9s | master passed |
| +1 :green_heart: | shadedjars | 6m 39s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 46s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 14s | the patch passed |
| +1 :green_heart: | compile | 1m 5s | the patch passed |
| +1 :green_heart: | javac | 1m 5s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 31s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 224m 59s | hbase-server in the patch passed. |
| | | 254m 35s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1811/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1811 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 4c6c90cb1b3a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 36a6ef9cf9 |
| Default Java | 1.8.0_232 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1811/1/testReport/ |
| Max. process+thread count | 3250 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1811/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#discussion_r433425854
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -450,7 +451,7 @@ public void run() {
private ProcedureStore procedureStore;
// the master local storage to store procedure data, etc.
- private LocalStore localStore;
+ private MasterRegion masterRegion;
Review comment:
Good.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java
##########
@@ -79,14 +79,14 @@
* Notice that, you can use different root file system and WAL file system. Then the above directory
* will be on two file systems, the root file system will have the data directory while the WAL
* filesystem will have the WALs directory. The archived HFile will be moved to the global HFile
- * archived directory with the {@link LocalRegionParams#archivedWalSuffix()} suffix. The archived
+ * archived directory with the {@link MasterRegionParams#archivedWalSuffix()} suffix. The archived
* WAL will be moved to the global WAL archived directory with the
- * {@link LocalRegionParams#archivedHFileSuffix()} suffix.
+ * {@link MasterRegionParams#archivedHFileSuffix()} suffix.
*/
@InterfaceAudience.Private
-public final class LocalRegion {
+public final class MasterRegion {
Review comment:
We still need the wrapper class with delegation? How about have the factory manage creation of the `HRegion` (wiring up the wal, &c) and `HMaster` hold the instance of `HRegion` directly?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1563,7 +1564,7 @@ protected void stopServiceThreads() {
private void createProcedureExecutor() throws IOException {
MasterProcedureEnv procEnv = new MasterProcedureEnv(this);
procedureStore =
- new RegionProcedureStore(this, localStore, new MasterProcedureEnv.FsUtilsLeaseRecovery(this));
+ new RegionProcedureStore(this, masterRegion, new MasterProcedureEnv.FsUtilsLeaseRecovery(this));
Review comment:
Having everything use a single region has me a little nervous. Seems like it'll make it easy for two unrelated subsystems to step on each others' toes later on -- conflicting row keys, columns, &c. This should be fine for initial work though.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -258,6 +259,14 @@
public static final String SPECIAL_RECOVERED_EDITS_DIR =
"hbase.hregion.special.recovered.edits.dir";
+ /**
+ * Whether to use {@link MetaCellComparator} even if we are not meta region. Used when creating
+ * master local region.
+ */
+ public static final String USE_META_CELL_COMPARATOR = "hbase.region.use.meta.cell.comparator";
Review comment:
If this configuration point is specific to master side, should it have `master` in its name?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegionFactory.java
##########
@@ -89,45 +82,8 @@
private static final TableDescriptor TABLE_DESC = TableDescriptorBuilder.newBuilder(TABLE_NAME)
.setColumnFamily(ColumnFamilyDescriptorBuilder.of(PROC_FAMILY)).build();
- private final LocalRegion region;
-
- private LocalStore(LocalRegion region) {
- this.region = region;
- }
-
- public void update(UpdateLocalRegion action) throws IOException {
- region.update(action);
- }
-
- public Result get(Get get) throws IOException {
- return region.get(get);
- }
-
- public RegionScanner getScanner(Scan scan) throws IOException {
- return region.getScanner(scan);
- }
-
- public void close(boolean abort) {
- region.close(abort);
- }
-
- @VisibleForTesting
- public FlushResult flush(boolean force) throws IOException {
- return region.flush(force);
- }
-
- @VisibleForTesting
- public void requestRollAll() {
- region.requestRollAll();
- }
-
- @VisibleForTesting
- public void waitUntilWalRollFinished() throws InterruptedException {
- region.waitUntilWalRollFinished();
- }
-
- public static LocalStore create(Server server) throws IOException {
- LocalRegionParams params = new LocalRegionParams().server(server)
Review comment:
👍
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -258,6 +259,14 @@
public static final String SPECIAL_RECOVERED_EDITS_DIR =
"hbase.hregion.special.recovered.edits.dir";
+ /**
+ * Whether to use {@link MetaCellComparator} even if we are not meta region. Used when creating
+ * master local region.
+ */
+ public static final String USE_META_CELL_COMPARATOR = "hbase.region.use.meta.cell.comparator";
Review comment:
It's a little nit-pick, but I like my configurations to specify components via `.`-separator, and use `_` for component names. So this might be `hbase.master.region.use_meta_cell_comparator`.
Of course, this might be conflicting with other configuration names and uses. Would need to look things over to see what else is using the `"hbase.master"` namespace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#discussion_r433582964
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java
##########
@@ -79,14 +79,14 @@
* Notice that, you can use different root file system and WAL file system. Then the above directory
* will be on two file systems, the root file system will have the data directory while the WAL
* filesystem will have the WALs directory. The archived HFile will be moved to the global HFile
- * archived directory with the {@link LocalRegionParams#archivedWalSuffix()} suffix. The archived
+ * archived directory with the {@link MasterRegionParams#archivedWalSuffix()} suffix. The archived
* WAL will be moved to the global WAL archived directory with the
- * {@link LocalRegionParams#archivedHFileSuffix()} suffix.
+ * {@link MasterRegionParams#archivedHFileSuffix()} suffix.
*/
@InterfaceAudience.Private
-public final class LocalRegion {
+public final class MasterRegion {
Review comment:
This is intentional. You can see the implementation of MasterRegion.update, we have to call `flusherAndCompactor.onUpdate();` after each update. So if we expose the HRegion directly, the callers have to do this by their own, and I believe it will be easy to forget and then cause big problem...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#discussion_r432913204
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java
##########
@@ -284,18 +284,21 @@ public static LocalRegion create(LocalRegionParams params) throws IOException {
Configuration conf = new Configuration(baseConf);
CommonFSUtils.setRootDir(conf, rootDir);
CommonFSUtils.setWALRootDir(conf, walRootDir);
- LocalRegionFlusherAndCompactor.setupConf(conf, params.flushSize(), params.flushPerChanges(),
+ MasterRegionFlusherAndCompactor.setupConf(conf, params.flushSize(), params.flushPerChanges(),
params.flushIntervalMs());
conf.setInt(AbstractFSWAL.MAX_LOGS, params.maxWals());
if (params.useHsync() != null) {
conf.setBoolean(HRegion.WAL_HSYNC_CONF_KEY, params.useHsync());
}
+ if (params.useMetaCellComparator() != null) {
Review comment:
For used as procedure store, this is not necessary. This is for preparing for storing root table in the future, as for root table, the row key is the same with meta table, and we need to use a special comparator. I think it is fine to change the comparator in the future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#discussion_r433453029
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java
##########
@@ -284,18 +284,21 @@ public static LocalRegion create(LocalRegionParams params) throws IOException {
Configuration conf = new Configuration(baseConf);
CommonFSUtils.setRootDir(conf, rootDir);
CommonFSUtils.setWALRootDir(conf, walRootDir);
- LocalRegionFlusherAndCompactor.setupConf(conf, params.flushSize(), params.flushPerChanges(),
+ MasterRegionFlusherAndCompactor.setupConf(conf, params.flushSize(), params.flushPerChanges(),
params.flushIntervalMs());
conf.setInt(AbstractFSWAL.MAX_LOGS, params.maxWals());
if (params.useHsync() != null) {
conf.setBoolean(HRegion.WAL_HSYNC_CONF_KEY, params.useHsync());
}
+ if (params.useMetaCellComparator() != null) {
Review comment:
ok
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegionFactory.java
##########
@@ -89,45 +82,8 @@
private static final TableDescriptor TABLE_DESC = TableDescriptorBuilder.newBuilder(TABLE_NAME)
.setColumnFamily(ColumnFamilyDescriptorBuilder.of(PROC_FAMILY)).build();
- private final LocalRegion region;
-
- private LocalStore(LocalRegion region) {
- this.region = region;
- }
-
- public void update(UpdateLocalRegion action) throws IOException {
- region.update(action);
- }
-
- public Result get(Get get) throws IOException {
- return region.get(get);
- }
-
- public RegionScanner getScanner(Scan scan) throws IOException {
- return region.getScanner(scan);
- }
-
- public void close(boolean abort) {
- region.close(abort);
- }
-
- @VisibleForTesting
- public FlushResult flush(boolean force) throws IOException {
- return region.flush(force);
- }
-
- @VisibleForTesting
- public void requestRollAll() {
- region.requestRollAll();
- }
-
- @VisibleForTesting
- public void waitUntilWalRollFinished() throws InterruptedException {
- region.waitUntilWalRollFinished();
- }
-
- public static LocalStore create(Server server) throws IOException {
- LocalRegionParams params = new LocalRegionParams().server(server)
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#issuecomment-636312796
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 19s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 7s | master passed |
| +1 :green_heart: | checkstyle | 1m 23s | master passed |
| +1 :green_heart: | spotbugs | 2m 15s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 55s | the patch passed |
| -0 :warning: | checkstyle | 1m 17s | hbase-server: The patch generated 4 new + 291 unchanged - 0 fixed = 295 total (was 291) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 12m 30s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | spotbugs | 2m 30s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. |
| | | 37m 30s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1811/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1811 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux 224d1c16da7a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 36a6ef9cf9 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1811/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 84 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1811/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#issuecomment-636308428
@ndimiduk PTAL. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#issuecomment-636308668
The new useMetaCellComparator parameter is for storing root table in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#issuecomment-636929864
Any other concerns? Need to rebase the patch for HBASE-24389 once this done.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#discussion_r432913252
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegionFactory.java
##########
@@ -89,45 +82,8 @@
private static final TableDescriptor TABLE_DESC = TableDescriptorBuilder.newBuilder(TABLE_NAME)
.setColumnFamily(ColumnFamilyDescriptorBuilder.of(PROC_FAMILY)).build();
- private final LocalRegion region;
-
- private LocalStore(LocalRegion region) {
- this.region = region;
- }
-
- public void update(UpdateLocalRegion action) throws IOException {
- region.update(action);
- }
-
- public Result get(Get get) throws IOException {
- return region.get(get);
- }
-
- public RegionScanner getScanner(Scan scan) throws IOException {
- return region.getScanner(scan);
- }
-
- public void close(boolean abort) {
- region.close(abort);
- }
-
- @VisibleForTesting
- public FlushResult flush(boolean force) throws IOException {
- return region.flush(force);
- }
-
- @VisibleForTesting
- public void requestRollAll() {
- region.requestRollAll();
- }
-
- @VisibleForTesting
- public void waitUntilWalRollFinished() throws InterruptedException {
- region.waitUntilWalRollFinished();
- }
-
- public static LocalStore create(Server server) throws IOException {
- LocalRegionParams params = new LocalRegionParams().server(server)
Review comment:
We will return MasterRegion directly after this change, so we do not need these methods any more, users can use the methods in MasterRegion directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#issuecomment-636325635
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 9s | master passed |
| +1 :green_heart: | compile | 1m 4s | master passed |
| +1 :green_heart: | shadedjars | 6m 2s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 44s | hbase-server in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 4s | the patch passed |
| +1 :green_heart: | compile | 1m 4s | the patch passed |
| +1 :green_heart: | javac | 1m 4s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 52s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 127m 37s | hbase-server in the patch passed. |
| | | 154m 1s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1811/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1811 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 2a2876b3a4e8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 36a6ef9cf9 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1811/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1811/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1811/1/testReport/ |
| Max. process+thread count | 4498 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1811/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
Apache9 merged pull request #1811:
URL: https://github.com/apache/hbase/pull/1811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#discussion_r432909987
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java
##########
@@ -284,18 +284,21 @@ public static LocalRegion create(LocalRegionParams params) throws IOException {
Configuration conf = new Configuration(baseConf);
CommonFSUtils.setRootDir(conf, rootDir);
CommonFSUtils.setWALRootDir(conf, walRootDir);
- LocalRegionFlusherAndCompactor.setupConf(conf, params.flushSize(), params.flushPerChanges(),
+ MasterRegionFlusherAndCompactor.setupConf(conf, params.flushSize(), params.flushPerChanges(),
params.flushIntervalMs());
conf.setInt(AbstractFSWAL.MAX_LOGS, params.maxWals());
if (params.useHsync() != null) {
conf.setBoolean(HRegion.WAL_HSYNC_CONF_KEY, params.useHsync());
}
+ if (params.useMetaCellComparator() != null) {
Review comment:
We need to add this in here?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java
##########
@@ -284,18 +284,21 @@ public static LocalRegion create(LocalRegionParams params) throws IOException {
Configuration conf = new Configuration(baseConf);
CommonFSUtils.setRootDir(conf, rootDir);
CommonFSUtils.setWALRootDir(conf, walRootDir);
- LocalRegionFlusherAndCompactor.setupConf(conf, params.flushSize(), params.flushPerChanges(),
+ MasterRegionFlusherAndCompactor.setupConf(conf, params.flushSize(), params.flushPerChanges(),
params.flushIntervalMs());
conf.setInt(AbstractFSWAL.MAX_LOGS, params.maxWals());
if (params.useHsync() != null) {
conf.setBoolean(HRegion.WAL_HSYNC_CONF_KEY, params.useHsync());
}
+ if (params.useMetaCellComparator() != null) {
Review comment:
This was missing?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegionFactory.java
##########
@@ -89,45 +82,8 @@
private static final TableDescriptor TABLE_DESC = TableDescriptorBuilder.newBuilder(TABLE_NAME)
.setColumnFamily(ColumnFamilyDescriptorBuilder.of(PROC_FAMILY)).build();
- private final LocalRegion region;
-
- private LocalStore(LocalRegion region) {
- this.region = region;
- }
-
- public void update(UpdateLocalRegion action) throws IOException {
- region.update(action);
- }
-
- public Result get(Get get) throws IOException {
- return region.get(get);
- }
-
- public RegionScanner getScanner(Scan scan) throws IOException {
- return region.getScanner(scan);
- }
-
- public void close(boolean abort) {
- region.close(abort);
- }
-
- @VisibleForTesting
- public FlushResult flush(boolean force) throws IOException {
- return region.flush(force);
- }
-
- @VisibleForTesting
- public void requestRollAll() {
- region.requestRollAll();
- }
-
- @VisibleForTesting
- public void waitUntilWalRollFinished() throws InterruptedException {
- region.waitUntilWalRollFinished();
- }
-
- public static LocalStore create(Server server) throws IOException {
- LocalRegionParams params = new LocalRegionParams().server(server)
Review comment:
How comes we can drop these methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #1811: HBASE-24474 Rename LocalRegion to MasterRegion
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1811:
URL: https://github.com/apache/hbase/pull/1811#discussion_r433583919
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -258,6 +259,14 @@
public static final String SPECIAL_RECOVERED_EDITS_DIR =
"hbase.hregion.special.recovered.edits.dir";
+ /**
+ * Whether to use {@link MetaCellComparator} even if we are not meta region. Used when creating
+ * master local region.
+ */
+ public static final String USE_META_CELL_COMPARATOR = "hbase.region.use.meta.cell.comparator";
Review comment:
For now it is only used in HMaster but I do not think it should be prefixed with hbase.master, as it is a configuration for HRegion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org