You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/07/03 18:23:22 UTC

[Bug 120177] New: WaE: filter/source/msfilter/escherex.cxx

https://issues.apache.org/ooo/show_bug.cgi?id=120177

          Priority: P3
            Bug ID: 120177
          Assignee: ooo-issues@incubator.apache.org
           Summary: WaE: filter/source/msfilter/escherex.cxx
          Severity: normal
        Issue Type: DEFECT
    Classification: Code
                OS: All
          Reporter: pavel@janik.cz
          Hardware: All
            Status: CONFIRMED
           Version: AOO 3.4.0
         Component: code
           Product: framework

Current trunk:

/Users/pavel/BUILD/BuildDir/ooo_trunk_src/filter/source/msfilter/escherex.cxx:
In function ‘sal_Int32 GetValueForEnhancedCustomShapeParameter(const
com::sun::star::drawing::EnhancedCustomShapeParameter&, const
std::vector<sal_Int32, std::allocator<sal_Int32> >&)’:
/Users/pavel/BUILD/BuildDir/ooo_trunk_src/filter/source/msfilter/escherex.cxx:2037:
warning: comparison between signed and unsigned integer expressions

Proposed change:


diff -ur filter.orig/source/msfilter/escherex.cxx
filter/source/msfilter/escherex.cxx
--- filter.orig/source/msfilter/escherex.cxx    2012-07-03 13:54:09.000000000
+0200
+++ filter/source/msfilter/escherex.cxx    2012-07-03 13:55:13.000000000 +0200
@@ -2019,12 +2019,12 @@

 sal_Int32 GetValueForEnhancedCustomShapeParameter( const
com::sun::star::drawing::EnhancedCustomShapeParameter& rParameter, const
std::vector< sal_Int32 >& rEquationOrder )
 {
-    sal_Int32 nValue = 0;
+    sal_uInt32 nValue = 0;
     if ( rParameter.Value.getValueTypeClass() == uno::TypeClass_DOUBLE )
     {
         double fValue;
         if ( rParameter.Value >>= fValue )
-            nValue = (sal_Int32)fValue;
+            nValue = (sal_uInt32)fValue;
     }
     else
         rParameter.Value >>= nValue;

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120177] WaE: filter/source/msfilter/escherex.cxx

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120177

pavel@janik.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from pavel@janik.cz ---
Fixed already by Oliver.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120177] WaE: filter/source/msfilter/escherex.cxx

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120177

hdu@apache.org <hd...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED
   Target Milestone|---                         |AOO 4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.