You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/11/01 22:20:27 UTC
[jira] [Commented] (TINKERPOP3-909) Improve steps that handle numeric data

    [ https://issues.apache.org/jira/browse/TINKERPOP3-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984550#comment-14984550 ] 

ASF GitHub Bot commented on TINKERPOP3-909:
-------------------------------------------

GitHub user dkuppitz opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/131

    TINKERPOP3-909: Improve steps that handle numeric data

    [TINKERPOP3-909: Improve steps that handle numeric data](https://issues.apache.org/jira/browse/TINKERPOP3-909)
    
    Integrated `NumberHelper` in `SumStep`, `MinStep`, `MaxStep` and `MeanStep` (`local` and `global` step variants). Had to change a few test methods where we now get different (but more appropriate) result types.
    
    All tests passed for me.
    
    VOTE: +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-909

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #131
    
----
commit d49deafb0d0c157bb59c26d6148993a8cccd64fb
Author: Daniel Kuppitz <da...@hotmail.com>
Date:   2015-10-31T11:07:50Z

    integrated NumberHelper in SumGlobalStep and SumLocalStep

commit eda16b504fda57f58d8d90a60421bde386528bba
Author: Daniel Kuppitz <da...@hotmail.com>
Date:   2015-10-31T17:42:09Z

    modified method/type signature of SumGlobalStep after getting some feedback from @okram

commit eba7114341b1257106db2111ed8b90b2012c0860
Author: Daniel Kuppitz <da...@hotmail.com>
Date:   2015-11-01T11:55:26Z

    Integrated NumberHelper in Min-, Max- and MeanStep

commit ccc3bfc31cdf84f7a25dc1f6da89b9dc42f5490a
Author: Daniel Kuppitz <da...@hotmail.com>
Date:   2015-11-01T21:13:17Z

    updated CHANGELOG and upgrade docs

commit e29a9362beb2cb2784a547b7f9e1e5d589c83d47
Author: Daniel Kuppitz <da...@hotmail.com>
Date:   2015-11-01T21:15:04Z

    Merge branch 'master' into TINKERPOP3-909
    
    Resolved Conflicts:
    	CHANGELOG.asciidoc
    	docs/src/upgrade-release-3.1.x-incubating.asciidoc

----


> Improve steps that handle numeric data
> --------------------------------------
>
>                 Key: TINKERPOP3-909
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-909
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.1.0-incubating
>            Reporter: Daniel Kuppitz
>            Assignee: Daniel Kuppitz
>             Fix For: 3.1.0-incubating
>
>
> Use the new {{NumberHelper}} (implemented in https://issues.apache.org/jira/browse/TINKERPOP3-861) in steps that are supposed to handle numeric data (e.g. {{Sum(Global)Step}}, {{Min(Global)Step)}}, {{Max(Global)Step}}, etc.). These steps currently simply convert everything into a {{Double}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)