[GitHub] [beam] davidyan74 commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

[GitBox <gi...@apache.org>]

davidyan74 commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely
URL: https://github.com/apache/beam/pull/11128#discussion_r394662812
 
 

 ##########
 File path: sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py
 ##########
 @@ -153,7 +153,8 @@ def __init__(
     self._coder = coder
     self._labels = labels
     self._is_cache_complete = (
-        is_cache_complete if is_cache_complete else lambda: True)
+        is_cache_complete if is_cache_complete else lambda _: True)
+    self._pipeline_id = labels[-1].split('_')[-1]
 
 Review comment:
   This looks kinda like a hack, and if we change the format of the label, this will break.
   Can we at least put the code that encodes and decodes labels in one place, perhaps in a util module, and have this line call the decode function?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services