You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/09 02:28:30 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #17001: Fix swagger annotation for analyzeBacklog endpoint

michaeljmarshall opened a new pull request, #17001:
URL: https://github.com/apache/pulsar/pull/17001

   ### Motivation
   
   See https://github.com/apache/pulsar/pull/16222 for the motivation.
   
   ### Modifications
   
   * Fix an incorrect description for the `authoritative` swagger annotation.
   
   ### Documentation
   - [x] `doc` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #17001: Fix swagger annotation for analyzeBacklog endpoint

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on code in PR #17001:
URL: https://github.com/apache/pulsar/pull/17001#discussion_r952116142


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java:
##########
@@ -1710,7 +1710,7 @@ public void analyzeSubscriptionBacklog(
             @PathParam("subName") String encodedSubName,
             @ApiParam(name = "position", value = "messageId to start the analysis")
             ResetCursorData position,
-            @ApiParam(value = "Is authentication required to perform this operation")
+            @ApiParam(value = "Whether leader broker redirected this call to this broker. For internal use.")

Review Comment:
   No, I meant to use the past tense for redirect because the redirect happened in the past. Thanks for asking.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #17001: Fix swagger annotation for analyzeBacklog endpoint

Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #17001:
URL: https://github.com/apache/pulsar/pull/17001


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #17001: Fix swagger annotation for analyzeBacklog endpoint

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #17001:
URL: https://github.com/apache/pulsar/pull/17001#issuecomment-1211496647

   @lhotari - PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #17001: Fix swagger annotation for analyzeBacklog endpoint

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #17001:
URL: https://github.com/apache/pulsar/pull/17001#discussion_r951248168


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java:
##########
@@ -1710,7 +1710,7 @@ public void analyzeSubscriptionBacklog(
             @PathParam("subName") String encodedSubName,
             @ApiParam(name = "position", value = "messageId to start the analysis")
             ResetCursorData position,
-            @ApiParam(value = "Is authentication required to perform this operation")
+            @ApiParam(value = "Whether leader broker redirected this call to this broker. For internal use.")

Review Comment:
   ```suggestion
               @ApiParam(value = "Whether leader broker redirects this call to this broker. For internal use.")
   ```
   Do you mean this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org