[GitHub] [bahir-flink] eskabetxe commented on a diff in pull request #155: [BAHIR-315] Redis connector: add Support for SSL connections for cluster

[GitBox <gi...@apache.org>]

eskabetxe commented on code in PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#discussion_r992514196


##########
flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java:
##########
@@ -47,14 +47,7 @@ public RedisClusterContainer(JedisCluster jedisCluster) {
     }
 
     @Override
-    public void open() throws Exception {
-
-        // echo() tries to open a connection and echos back the
-        // message passed as argument. Here we use it to monitor
-        // if we can communicate with the cluster.
-
-        jedisCluster.echo("Test");
-    }
+    public void open() throws Exception {}

Review Comment:
   why the "jedisCluster.echo("Test")" is removed?
   
   this could create any colateral? 
   this is more an optimization than a need from the bump version no?



##########
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java:
##########
@@ -78,7 +79,25 @@ public void testRedisClusterDownBehavior() throws Exception {
             .setMaxTotal(1)
             .setMinIdle(1).build();
 
-        testDownBehavior(wrongJedisClusterConfig);
+        RedisSink<Tuple2<String, String>> redisSink = new RedisSink<>(wrongJedisClusterConfig,

Review Comment:
   why change this?
   its the same code as testDownBehavior no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org