You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/16 20:52:09 UTC

[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #2523: Fix Redundant ScalarValue Boxed Collection

comphead commented on code in PR #2523:
URL: https://github.com/apache/arrow-datafusion/pull/2523#discussion_r874146979


##########
datafusion/common/src/scalar.rs:
##########
@@ -934,16 +928,20 @@ impl ScalarValue {
                         match values {
                             Some(values) => {
                                 // Push value for each field
-                                for c in 0..columns.len() {
-                                    let column = columns.get_mut(c).unwrap();
-                                    column.push(values[c].clone());
+                                for (i, v) in

Review Comment:
   clippy complained on that :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org